Okin7 Reporter
	Description • 19 years ago

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fr-FR; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr-FR; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

When displaying this code :

<select multiple="multiple">
    <optgroup label="Label">
        <option label="a">a</option>
        <option label="a">a</option>
        <option label="a">a</option>
    </optgroup>
</select>

The height of the widget is set to 3 rows although there is 4 rows in the box.
The width also is to small, as the scrollbar is not over the end of the label.

Reproducible: Always

Steps to Reproduce:

	Martijn Wargers (dead)
	Comment 2 • 19 years ago

I'm also seeing this in the latest trunk build.
It seems to me that Mozilla doesn't look at the eventuel presence of an
<optgroup> here.

	Mats Palmgren (inactive) Assignee
	Comment 6 • 19 years ago

These two changes are not needed to fix this bug:
Removed an unused parameter from GetMaxOptionHeight().
Make sure GetNumberOfOptions() assigns the out parameter even if it fails.

	Boris Zbarsky [:bzbarsky]
	Comment 8 • 19 years ago

Comment on attachment 189490 [details] [diff] [review]
Patch rev. 1

>Index: layout/forms/nsListControlFrame.cpp
>+      nsIPresShell* shell = aPresContext->GetPresShell();

I think you can safely use aPresContext->PresShell() and skip the null-check.

r+sr=bzbarsky with that.

	Mats Palmgren (inactive) Assignee
	Comment 9 • 19 years ago

Right, fixed that.

	Mats Palmgren (inactive) Assignee
	Comment 10 • 19 years ago

Checked in to trunk 2005-07-23 18:02 PDT

-> FIXED