See bug 295937 comment 1, bug 295937 comment 4, bug 295937 comment 5

Thoughts: could we optimize the attribute case by using specialized, thinner get and set hooks? Should we add JSPROP_READONLY if the attribute is readonly? /be

That patch fixes the issue for me.

Reviewers flush your queues! ;-) /be

Comment on attachment 189140 [details] [diff] [review] proposed fix, v2 r=jst

Comment on attachment 189140 [details] [diff] [review] proposed fix, v2 sr=shaver. I think we should JSPROP_READONLY if the property is readonly, but we can do that in a follow-on.

Comment on attachment 189140 [details] [diff] [review] proposed fix, v2 self-approving, we need this for XPCNativeWrapper victory in 1.8/1.1. /be

Fixed. Not sure about the JSPROP_READONLY -- do I need a followup bug? I'll file something, or wiki at least. /be

jst points out that we want to try setting the wn attribute from the nw, so that we get high-fidelity XPConnect exception-throwing on readonly attribute, instead of bad ol' ECMA silent-failure-to-mutate-but-return-the-RHS-value-to-confuse-you behavior. /be

So... any idea why luna went orange?

No. I could back out and see if it goes green again. Anyone have access and the know-how to extract why the DHTMLTest: test failed? /be

Backed out, we'll see what luna does. /be

Grrr, why would this break the DHTMLTest? I'll try to make time (new baby is nigh so I may not be able to). /be

brendan, I ran into some major weirdness that I traced to this patch... if you load this testcase in a build with the patch and follow directions, the second click on the button does nothing. For some reason, the XPCWrappedNative that has the event handler defined on it gets garbage collected when that second window is opened... In fact, XPCWrappedNative preservation seems broken in general with this patch applied. :( (And yes, I meant XPCWrappedNative above, not XPCNativeWrapper. Why this patch affects XPCWrappedNatives, I do not know.)

OK, I think I know what's going on here... I filed bug 301316 on the problem.

Testing help welcome, too. /be

Comment on attachment 189822 [details] [diff] [review] proposed fix, v3 r=shaver.

Comment on attachment 189822 [details] [diff] [review] proposed fix, v3 This patch doesn't fix the issue... when running with it, I get nativeExists false in almost all cases (including resolves of "firstChild", "nextSibling", etc, in particular).

Checked in "proposed fix, v2" for brendan as requested.

I guess this was left for me to close. /be