http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1121350680&maxdate=1121354639 There were 2 checkins in that timeframe, and since bug 290354 caused some Tp regressions, it might be the cause of the increased leakage aswell. From: RLk:3.58KB Lk:297KB MH:7.67MB A:215K To: RLk:4.98KB Lk:300KB MH:7.78MB A:219K

The log says: --NEW-LEAKS-----------------------------------leaks------leaks%----------------------- nsGenericElement 700 - nsNodeInfoManager 40 - nsHashtable 88 - nsEventListenerManager 1100 - nsPrincipal 240 - nsGenericDOMDataNode 644 - nsCSSDeclaration 56 - nsDOMEventGroup 12 - nsCSSRule 40 - nsNodeInfo 64 - nsStandardURL 368 100.00% nsLocalFile 720 20.00% TOTAL 4072

Aaron, time is getting short for 1.8b4. Can you please look into this quickly?

I suspect the fix for bug 300783 will take care of this as well.

Yeah, this got fixed by bug 300783.

Actually, no. The checkin for bug 290354 might have fixed some leaks, but by no means all. If nothing else, the following line in nsListControlFrame::FireMenuItemActiveEventleaks: 2649 nsCOMPtr<nsIContent> optionContent = GetOptionContent(focusedIndex);

Needs careful testing (I've already spent several hours on this, and that's all the time I'll be able to spend on it for the foreseeable future).

Er, I meant checkin for bug 300783. The checkin for bug 290354 is what caused this, of course....

Blocking for 1.8b4 since it's a regression. Need some QA on this after the patch lands, per Comment 6. Boris -> do you need a review prior to landing?

Yes, this needs review. It also needs at least minimal testing to make sure it fixes the leak and that things still work before said review is requested. I've done no testing past making sure it compiles.

(In reply to comment #9) > Yes, this needs review. It also needs at least minimal testing to make sure it > fixes the leak and that things still work before said review is requested. I've > done no testing past making sure it compiles. With Boris' patch the correct accessibility events are still fired.

Comment on attachment 190625 [details] [diff] [review] This should fix it, maybe... Whichever one of you gets to this could you shoud r+sr= it since we're short on time? I've tested that it doesn't regress accessibility.

Comment on attachment 190625 [details] [diff] [review] This should fix it, maybe... nsIContent* content = nsnull; This line is no longer needed, remove it.

Comment on attachment 190625 [details] [diff] [review] This should fix it, maybe... Requesting approval for this leak fix.