Closed Bug 301197 Opened 19 years ago Closed 19 years ago

Need --disable-compile-environment flag

Categories

(Firefox Build System :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.8beta4

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

(Whiteboard: has patch, needs review cls+chase)

Attachments

(1 file, 2 obsolete files)

For the l10n build system I want to be able to configure the tree without a compiler present. This would be used for chrome packaging and other kinds of makefile rules. I intend to use the --disable-compile-environment flag unless there is a better name suggested.
Blocks: 300409
so... why does this need a configure flag? Why not just ./configure && make chrome?
Because configure will still check for a compiler/etc, which will not be present on many localizer's machines.
Flags: blocking1.8b4+
Priority: -- → P1
Target Milestone: --- → mozilla1.9alpha
Target Milestone: mozilla1.9alpha → mozilla1.8beta4
Attached patch Add --disable-compile-environment, rev. 1 (obsolete) (deleted) — Splinter Review
Attachment #189705 - Flags: superreview?(chase)
Attachment #189705 - Flags: review?(cls)
Whiteboard: has patch, needs review cls+chase
Comment on attachment 189705 [details] [diff] [review] Add --disable-compile-environment, rev. 1 I'm out of the loop so I'm not totally convinced of the need to jump through hoops to support a compiler-less environment. Regarding the patch: * why only look for nsinstall during the non-compiler builds? If we can use the system version for this special case,then we should be able to use it always * you moved AC_PROG_AWK which will cause the msvc version checks to fail because they use $AWK * IMO, you should keep the $COMPILE_ENVIRONMENT if statements on their own line * why is only a portion of the MOZ_ENABLE_QT ifdef disabled? l10n doesn't use moc, does it? * the patch removes the MOZ_BYPASS_PROFILE_AT_STARTUP define used(?) by the tinderboxes * the client.mk changes are harmless but what's the point of them?
Attachment #189705 - Flags: review?(cls) → review-
Attached patch Add --disable-compile-environment, rev. 1.1 (obsolete) (deleted) — Splinter Review
Attachment #189705 - Attachment is obsolete: true
Attachment #190415 - Flags: superreview?(chase)
Attachment #190415 - Flags: review?(cls)
Attachment #189705 - Flags: superreview?(chase)
> * the patch removes the MOZ_BYPASS_PROFILE_AT_STARTUP define used(?) by the > tinderboxes Not used for anything any more. > * the client.mk changes are harmless but what's the point of them? So that the tinderbox can call "make -f client.mk configure"
Attachment #190415 - Flags: superreview?(chase) → superreview+
Comment on attachment 190415 [details] [diff] [review] Add --disable-compile-environment, rev. 1.1 In config.mk, NSINSTALL shouldn't take the -t option by default. INSTALL should be set for the system nsinstall case using the existing ifdefs. FWIW, conditionally calling macros puts us that much further away from ever upgrading to autoconf 2.5x (bug 104642).
Attachment #190415 - Flags: review?(cls) → review-
Fixed config.mk to separate the NSINSTALL and INSTALL settings.
Attachment #190415 - Attachment is obsolete: true
Attachment #190585 - Flags: approval1.8b4?
Attachment #190585 - Flags: approval1.8b4? → approval1.8b4+
Fixed on trunk for 1.8b4
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
This bug has caused Bug 303292
Depends on: 303292
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: