Closed Bug 302402 Opened 19 years ago Closed 19 years ago

Source links in JavaScript console open twice

Categories

(Core Graveyard :: Error Console, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.8beta4

People

(Reporter: jruderman, Assigned: aaronlev)

References

Details

(Keywords: regression)

Attachments

(1 file)

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050727 Firefox/1.0+ Steps to reproduce: 1. Load any page that results in an error in the JavaScript console, such as http://www.google.com/. 2. Open the JavaScript console. 3. Click the link in an error message. Result: Source code opens in two Firefox windows. One scrolls to the correct position and the other does not.
Also happens with the "Visit home page" link in an extension's About window. I wonder if this bug is a regression from Aaron's recent work with XUL hyperlinks (e.g. in bug 301398).
Flags: blocking1.8b4?
It must be from me.
I see this bug in a July 27 nightly but not in a July 25 nightly.
Keywords: regression
Assignee: js-console → aaronleventhal
Just confirming it's still there for Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050728 Firefox/1.0+ Is it just me or is there some doubling up of the errors in the javascript console itself too?
Flags: blocking1.8b4? → blocking1.8b4+
OS: MacOS X → All
Hardware: Macintosh → All
Same for Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050730 Firefox/1.0+ HW, OS => ALL
*** Bug 303082 has been marked as a duplicate of this bug. ***
Comment on attachment 190945 [details] [diff] [review] 1) about extension link doesn't need onclick since href takes care of opening the link, 2) js console links need to prevent default since they have a special way of opening to a specific line # > <handlers> >- <handler event="click" button="0"><![CDATA[ >+ <handler event="click" phase="capturing" button="0"><![CDATA[ >+ event.preventDefault(); You can just add preventdefault="true" to the handler here. It'd also be nice if you could move <![CDATA[ onto its own line. >Index: toolkit/content/widgets/text.xml >=================================================================== >RCS file: /cvsroot/mozilla/toolkit/content/widgets/text.xml,v >retrieving revision 1.15 >diff -p -u -5 -r1.15 text.xml >--- toolkit/content/widgets/text.xml 20 Jul 2005 08:40:13 -0000 1.15 >+++ toolkit/content/widgets/text.xml 29 Jul 2005 13:41:49 -0000 >@@ -291,21 +291,24 @@ > </property> > <property name="href" onget="return this.getAttribute('href');" > onset="this.setAttribute('href', val); return val;" /> > </implementation> > <handlers> >- <handler event="click"> >+ <handler event="click" phase="capturing" button="0"> > <![CDATA[ >+ if (event.getPreventDefault()) { >+ return; >+ } please drop the extra brackets, I know we're inconsistent sometimes, but there's two other examples in the same function.
Attachment #190945 - Flags: review?(mconnor)
Attachment #190945 - Flags: review+
Attachment #190945 - Flags: approval1.8b4+
Checking in toolkit/components/console/content/consoleBindings.xml; /cvsroot/mozilla/toolkit/components/console/content/consoleBindings.xml,v <-- consoleBindings.xml new revision: 1.9; previous revision: 1.8 done Checking in toolkit/content/widgets/text.xml; /cvsroot/mozilla/toolkit/content/widgets/text.xml,v <-- text.xml new revision: 1.17; previous revision: 1.16 done Checking in toolkit/mozapps/extensions/content/about.xul; /cvsroot/mozilla/toolkit/mozapps/extensions/content/about.xul,v <-- about.xul new revision: 1.7; previous revision: 1.6 done
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Works fine with current CVS build Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050805 Firefox/1.0+
Status: RESOLVED → VERIFIED
Target Milestone: --- → mozilla1.8beta4
Product: Core → SeaMonkey
Product: SeaMonkey → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: