Closed
Bug 302438
Opened 20 years ago
Closed 19 years ago
Leaking nsFloatCache objects when image is aligned
Categories
(Core :: Layout: Floats, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
()
Details
(Keywords: memory-leak)
Attachments
(1 file)
|
(deleted),
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
BUILD: Current trunk
STEPS TO REPRODUCE: Load testcase URL. Reload a couple of times. Leak one
nsFloatCache per reload.
NOTES: If I use a div, span, or image without a URI, I don't leak.
|
Assignee | |
Comment 1•20 years ago
|
||
Note that this leaks on various mozilla.org pages...
Flags: blocking1.8b4?
|
||
Comment 2•20 years ago
|
||
not a blocker but if there's a simple fix we should take it.
Flags: blocking1.8b4? → blocking1.8b4-
|
||
Updated•20 years ago
|
|
|
||
Updated•20 years ago
|
|
|
||
Comment 3•20 years ago
|
||
Worksforme.
|
|
Assignee | |
Comment 4•20 years ago
|
||
Hmm... I can't reproduce it anymore either...
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → WORKSFORME
|
|
Assignee | |
Comment 5•19 years ago
|
||
OK, I think I'm seeing this again -- this is the cause of the latest refcount
leak jump on the Firefox trunk balsa build (the Oct 16 jump).
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
|
|
Assignee | |
Comment 6•19 years ago
|
||
Er... maybe not. This testcase still doesn't seem to leak... I'll try to
minimize the page that does. :(
|
|
Assignee | |
Updated•19 years ago
|
Status: REOPENED → RESOLVED
Closed: 20 years ago → 19 years ago
Resolution: --- → WORKSFORME
|
|
Assignee | |
Comment 7•19 years ago
|
||
OK, reopening again. It looks like align="left" leaks, but style="float:left"
does not. I have no idea how that happens. :(
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
|
|
Assignee | |
Updated•19 years ago
|
Summary: Leaking nsFloatCache objects when image is floating → Leaking nsFloatCache objects when image is aligned
|
|
Assignee | |
Comment 8•19 years ago
|
||
So we leak a float cache any time we remove a float from a line...
The assertions and extra logging are cosmetic; the nsBlockReflowState fixes
another leak, as far as I can tell.
|
|
Assignee | |
Updated•19 years ago
|
Attachment #200389 -
Flags: superreview?(dbaron)
Attachment #200389 -
Flags: review?(dbaron)
|
|
||
Updated•19 years ago
|
Attachment #200389 -
Flags: superreview?(dbaron)
Attachment #200389 -
Flags: superreview+
Attachment #200389 -
Flags: review?(dbaron)
Attachment #200389 -
Flags: review+
|
|
Assignee | |
Updated•19 years ago
|
Assignee: nobody → bzbarsky
Status: REOPENED → NEW
Target Milestone: --- → mozilla1.9alpha
|
|
Assignee | |
Comment 9•19 years ago
|
||
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → FIXED
|
||
Comment 10•19 years ago
|
||
As a fixed memory leak bug, could this be considered for 1.8rc2 ?
Flags: blocking1.8rc2?
|
|
Assignee | |
Comment 11•19 years ago
|
||
This isn't a big leak, really, and I just don't think it's worth the risk of changes to 1.8 at this point.
Flags: blocking1.8rc2? → blocking1.8rc2-
|
|
Assignee | |
Comment 12•19 years ago
|
||
*** Bug 68805 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•