Closed Bug 302916 Opened 19 years ago Closed 19 years ago

Trunk crash [@ nsFocusController::GetWindowFromDocument]

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: allan, Assigned: jst)

References

Details

(Keywords: crash, testcase, topcrash)

Crash Data

Attachments

(2 files)

Testcase
(deleted), application/xhtml+xml
Details
Patch
(deleted), patch
jst
: review+
jst
: superreview+
benjamin
: approval1.8b4+
Details | Diff | Splinter Review
FF trunk crashes for me in nsFocusController::GetWindowFromDocument(), as it does not null-check doc->GetScriptGlobalObject().
Attached file Testcase (deleted) —
Not exactly "the simplest testcase in the world" :( Needs XForms support too. 1. view another page with a link to this testcase 2. view this testcase 3. press "insert at 3" 4. press the back-button in Firefox -> crash
Attached patch Patch (deleted) — — Splinter Review
Simple null-check. Might just be hiding the real problem, dunno, it's the first time I've ventured into dom/ :)
Attachment #191182 - Flags: superreview?(jst)
Attachment #191182 - Flags: review?(jst)
Severity: major → critical
Keywords: crash
Keywords: testcase
(In reply to comment #3) > Dupe of bug 302894? Looks like it.
Comment on attachment 191182 [details] [diff] [review] Patch Yeah, this does look like the right thing to do here. r+sr=jst. Thanks for the patch!
Attachment #191182 - Flags: superreview?(jst)
Attachment #191182 - Flags: superreview+
Attachment #191182 - Flags: review?(jst)
Attachment #191182 - Flags: review+
Attachment #191182 - Flags: approval1.8b4?
*** Bug 302894 has been marked as a duplicate of this bug. ***
*** Bug 302880 has been marked as a duplicate of this bug. ***
Attachment #191182 - Flags: approval1.8b4? → approval1.8b4+
Adding topcrash+ keyword since this is a recent regression starting 7/31, we have a testcase, and a patch ready to go. Assigning to jst since he made some changes recently to that part of the code. Let's get this patched up.
Assignee: general → jst
Keywords: topcrash
Summary: crash @ nsFocusController::GetWindowFromDocument() → Trunk crash [@ nsFocusController::GetWindowFromDocument]
Fix checked in, thanks for the patch!
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
*** Bug 302956 has been marked as a duplicate of this bug. ***
Verified FIXED using build 2005-08-02-05 on Windows XP SeaMonkey trunk.
Status: RESOLVED → VERIFIED
Crash Signature: [@ nsFocusController::GetWindowFromDocument]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: