XUL Accesskey FAQ and Policies, section How do I pick an accesskey letter? 3. Make it easy to see says: * Use letters at the beginning of the first or second word of the label. * Use a distinctive consonant or a vowel in the label. * Use letters with wide widths, such as w, m, and capital letters. * Avoid Letters with descenders, such as p, g, q, or y. * Letters next to a letter with a descender. * Letters that are only one pixel wide, such as i or l. Now, Deer Park alpha 2 rv: 1.8b4 build 20050805 has Edit/Find A(g)ain Tools/Options.../Privacy category/Cookies tab/ [] A(l)low site to set cookies [] For the ori(g)inating site only Tools/Options.../Privacy category/Cache tab/ Use u(p) to ... Tools/Options.../Content category/ A(l)lowed Sites button Tools/Options.../Content category/ [] but disable common anno(y)ances Tools/Options.../Advanced category/General tab/ Accessibility fieldset [] Be(g)in finding when you begin typing Tools/Options.../Advanced category/Security tab/ Certificates fieldset Securit(y) devices button http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dnacc/html/ATG_KeyboardShortcuts.asp also recommends to avoid chosing letters with descenders for accesskey and avoid chosing i or l as accesskey I chose component Keyboard navigation; if this is wrong or inappropriate, please update that field. Thanks.

See bug 191642 comment 33 and the comments following it.

Can't block on this, since we need core changes to allow accesskeys per tabpabel, not in scope for 1.8.1

(In reply to comment #2) > Can't block on this, since we need core changes to allow accesskeys per > tabpabel, not in scope for 1.8.1 aka bug 143065

Yes, a lot of forums have the post/reply button set to accesskey "s" which no longer works in 2.0 as this just opens the history menu!

.../library/en-us/dnacc/html/ATG_KeyboardShortcuts.asp is now http://msdn2.microsoft.com/en-us/library/bb545460.aspx

Now that bug 143065 is fixed, this one can be fixed finally as well. The current state of access keys in the Preferences dialog is awful. The changes required to make this work are trivial, and provide a great polish on the Preferences dialog keyboard accessibility. Therefore, I'm requesting blocking on this one. Even if it's not deemed as blocking, I guess it still deserves wanted-firefox3+.

Improve access keys used in the Preferences dialog and its decedents. Here are some notes to make the review on this patch easier: * The changes in advanced-scripts.xul were made in order to make the button label (E)xceptions instead of E(x)ceptions. * The change in advanced.xul was made in order for the access key on the label to actually show in the UI. * In several places, the change of the access keys were edited in order to comply with <http://developer.mozilla.org/en/docs/XUL_Accesskey_FAQ_and_Policies>. * The changes in toolkit/mozapps/preferences were made to enable access keys on the Change Master Password and Remove Master Password dialogs which are accessible through the Preferences dialog. * The change in passwordManager.dtd was made to make the access key for the Clear button the same as that of the cookies dialog with this patch applied. The previous choice of access key (l) was a poor one. * I have tested each and every access key in the Preferences dialog or one of its decedents with this patch applied, and verified that I have not accidentally created any duplicate access keys, etc.

This does not block the final release of Firefox 3.

> .../library/en-us/dnacc/html/ATG_KeyboardShortcuts.asp > also recommends to avoid chosing letters with descenders for accesskey and avoid > chosing i or l as accesskey Another URL for that Microsoft /library/en-us/dnacc/html/ATG_KeyboardShortcuts.asp document is also now Guidelines for Keyboard User Interface Design, section Selecting Access Keys http://msdn2.microsoft.com/en-us/library/ms971323.aspx

mano: ping...

Ping?

Comment on attachment 302108 [details] [diff] [review] Patch (v1) I'm really sorry for missing this. This UI changed much since this was coded. Clearing review for now. I'll review it promptly if you decide to update it.

Updating to reality: I won't have the time to work on this for the foreseeable future!

Looks like only the Security Devices button is still an issue. "D" is available?

(In reply to Gérard Talbot from comment #5) > .../library/en-us/dnacc/html/ATG_KeyboardShortcuts.asp > is now > http://msdn2.microsoft.com/en-us/library/bb545460.aspx is now at https://msdn.microsoft.com/en-us/library/dn742465.aspx and has a lot of information and it states " (...) Prefer characters that appear early in the label, ideally the first character of the first or second word. Prefer a distinctive consonant or a vowel, such as "x" in "Exit." Prefer characters with wide widths, as w, m, and capital letters. Avoid using characters that make the underline difficult to see, such as letters that are one pixel wide, letters with descenders, and letters next to a letter with a descender. (...) " Another relevant document at MSDN: Guidelines for Keyboard User Interface Design Selecting Access Keys; Make access keys discoverable. https://msdn.microsoft.com/en-us/library/ms971323.aspx#atg_keyboardshortcuts_selecting_access_keys