Closed
Bug 303865
Opened 19 years ago
Closed 18 years ago
a11y: Should be able to select items in select1 via keypressed (not arrow keys)
Categories
(Core Graveyard :: XForms, enhancement)
Core Graveyard
XForms
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: allan, Assigned: surkov)
References
()
Details
(Keywords: fixed1.8.0.8, fixed1.8.1.1)
Attachments
(2 files, 1 obsolete file)
Pressing f.x. "v" in a select1 should select the first element starting with a
"v", as a html:select does. Try f.x. attachment 190005 [details].
*** Bug 316618 has been marked as a duplicate of this bug. ***
Also, if you type out a value, that value should be selected.
Summary: Should be able to select items in select1 via keypressed (not arrow keys) → a11y: Should be able to select items in select1 via keypressed (not arrow keys)
|
Reporter | |
Updated•19 years ago
|
Severity: normal → enhancement
|
|
Reporter | |
Updated•18 years ago
|
Assignee: aaronr → xforms
|
Assignee | |
Updated•18 years ago
|
Blocks: xformsa11y
|
|
Assignee | |
Comment 3•18 years ago
|
||
Assignee: xforms → surkov.alexander
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•18 years ago
|
||
Attachment #236826 -
Flags: review?(Olli.Pettay)
|
|
Assignee | |
Comment 5•18 years ago
|
||
<method name="selectItemByLabel">
<parameter name="aValue"/>
<parameter name="aContextNode"/>
Last parameter is needless. Costs of testing :)
|
||
Comment 6•18 years ago
|
||
Comment on attachment 236826 [details] [diff] [review]
patch
>+ } else if (aEvent.charCode && !this.selectionOpen) {
>+ // Cache sequence of last pressed keys and search it in value of
>+ // xforms:label inside xforms:item elements.
>+ this.searchedHitCount++;
>+ window.setTimeout(
>+ function(aSelect) {
>+ if (!--aSelect.searchidHitCount)
>+ aSelect.searchedValue = "";
>+ },
>+ 1000,
>+ this);
Why this timeout is needed? If you have a good reason, add a comment to the code too ;)
And why the timeout is 1sec?
Attachment #236826 -
Flags: review?(Olli.Pettay) → review-
|
|
Assignee | |
Comment 7•18 years ago
|
||
(In reply to comment #6)
>
> Why this timeout is needed? If you have a good reason, add a comment to the
> code too ;)
> And why the timeout is 1sec?
>
Right, timeout is not needed. 1 sec is time of html:select http://lxr.mozilla.org/seamonkey/source/layout/forms/nsListControlFrame.cpp#105
Attachment #236826 -
Attachment is obsolete: true
Attachment #237125 -
Flags: review?(Olli.Pettay)
|
|
||
Updated•18 years ago
|
Attachment #237125 -
Flags: review?(Olli.Pettay) → review+
|
|
Assignee | |
Updated•18 years ago
|
Attachment #237125 -
Flags: review?(aaronr)
Attachment #237125 -
Flags: review?(aaronr) → review+
|
|
Assignee | |
Comment 8•18 years ago
|
||
checked in by smaug for me
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
|
||
Comment 10•18 years ago
|
||
checked into 1.8 branch on 2006/11/21
Keywords: fixed1.8.1.1
Whiteboard: xf-to-branch
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•