Ria Klaassen (not reading all bugmail) Reporter
	Description • 19 years ago

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050815 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050815 Firefox/1.0+

The Add Bookmark dialog contains a folder "Bookmarks Toolbar" which generates an
error in the JS console when I click on it:

Error: [Exception... "Component returned failure code: 0x80004005
(NS_ERROR_FAILURE) [nsIRDFContainer.Init]"  nsresult: "0x80004005
(NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://browser/content/bookmarks/addBookmark2.js :: onOK :: line 154"  data: no]
Source File: chrome://browser/content/bookmarks/addBookmark2.js
Line: 154

There is already an entry present called "Bookmarks Toolbar Folder" which works
fine.



Reproducible: Always

Steps to Reproduce:
1. Rightclick on the page; choose Bookmark This Page
2. In the dialog click the blue arrow and choose Bookmarks Toolbar and click OK.



Actual Results:  
Nothing, only an error in the JS Console

Expected Results:  
?

Superfluous folder?

	Ria Klaassen (not reading all bugmail) Reporter
	Comment 1 • 19 years ago

See also:
http://forums.mozillazine.org/viewtopic.php?p=1674429#1674429

	Ria Klaassen (not reading all bugmail) Reporter
	Comment 2 • 19 years ago

When I click the orange feed icon on a feed page like
http://planet.mozilla.org/rss20.xml the Add Livemark Dialog shows similar
behaviour; the only difference is that when I choose to store the livemark in
"Bookmarks Toolbar", it stores it in the main folder (without an error).

	Peter van der Woude [:Peter6]
	Comment 3 • 19 years ago

this is odd, at home and work i have an identical setup (extensions and all).
At work is see the problem at home it works as expected.
In neither case do i see a JSC error

	Phil Ringnalda (:philor)
	Comment 4 • 19 years ago

Error: [Exception... "Component returned failure code: 0x80004005
(NS_ERROR_FAILURE) [nsIRDFContainer.Init]"  nsresult: "0x80004005
(NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://browser/content/bookmarks/addBookmark2.js :: onOK :: line 154"  data: no]
Source File: chrome://browser/content/bookmarks/addBookmark2.js
Line: 154

while trying to use the extra entry for normal bookmarking (livebookmarks work
per comment 0, just going to the wrong place).

	Martijn Wargers (dead)
	Comment 5 • 19 years ago

This is probably happening because of this checkin of bug 303848:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/browser/components/bookmarks/content&command=DIFF_FRAMESET&file=addBookmark2.xul&rev1=1.19&rev2=1.20&root=/cvsroot

	Tracy Walker [:tracy]
	Comment 6 • 19 years ago

On Mac and Linux Deer Park as well.

	Mike Connor [:mconnor] Assignee
	Comment 7 • 19 years ago

fixes the bug by setting the proper BTF id on the menuitem.

also fixes being able to get a context menu on the Bookmarks->Bookmark All
Tabs... menuitem.  Kinda hacky, but this all goes away soon enough.

	Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)
	Comment 8 • 19 years ago

Comment on attachment 193380 [details] [diff] [review]
fix

hacks on top of hacks, r=me all the way!

	amano
	Comment 9 • 19 years ago

Hmm. Someone still needs to check this in on the branch.

	Mike Connor [:mconnor] Assignee
	Comment 10 • 19 years ago

Fixed, branch and trunk.

	Peter van der Woude [:Peter6]
	Comment 11 • 19 years ago

Not fixed on trunk

XML Parsing Error: not well-formed.
Location:chrome://browser/content/bookmarks/addBookmark2.xul
Line number 64, Column 1:

<<<<<<< addBookmark2.xul
^ 

i removed "fixed1.8" , don't know if trunk has the same problem so i won't reopen

	Asaf Romano (gone)
	Comment 12 • 19 years ago

I have checked in a fix earlier today (trunk in OK, btw), resolving again.

	Peter van der Woude [:Peter6]
	Comment 13 • 19 years ago

(In reply to comment #11)
> Not fixed on trunk
err, not fixed on BRANCH

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050824
Firefox/1.0+ ID:2005082500

it still worked in the 23:44pdt build

	Peter van der Woude [:Peter6]
	Comment 14 • 19 years ago

thanks Asaf

	Tracy Walker [:tracy]
	Comment 15 • 19 years ago

This isn't fixed on the branch as seen on Linux build 2005-08-25-05-mozilla1.8 
Also, now the default selected "Bookmarks" selection in the Add Bookmarks dialog
doesn't work.  However, the other "Bookmarks" item below the seperator does work.

This may not have ben checked in early emough to get into the nightly build. 
Leaving status as is. I'll check again with tomorrows build. Was the other issue
was corrected at the same time?

	Ria Klaassen (not reading all bugmail) Reporter
	Comment 17 • 19 years ago

The problem is still there.
Under the blue arrow (the most left one of the two) there is a double:
"Bookmarks Toolbar". See screenshot.
This double does not work.
A solution might be to delete to whole left arrow. One arrow should be enough. :)

	Matt Leidholm
	Comment 18 • 19 years ago

Ria: You are right about the duplication being a problem. We've had a similar
problem with two "Bookmarks" entries since the new-and-improved bookmarks
diologue was checked in.

However, this bug is about the crash and only the crash. I encourage you to file
another bug for the duplication problem.

	Marcia Knous [:marcia]
	Comment 19 • 19 years ago

Tracy: I see the same behavior on today's Mac build - Mozilla/5.0 (Macintosh; U;
PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050825 Firefox/1.0+. Also, when
you click on the drop widget is it then supposed to generate the "New Folder"
button, or that supposed to be there all of the time?

(In reply to comment #15)
> This isn't fixed on the branch as seen on Linux build 2005-08-25-05-mozilla1.8 
> Also, now the default selected "Bookmarks" selection in the Add Bookmarks dialog
> doesn't work.  However, the other "Bookmarks" item below the seperator does work.
> 
> This may not have ben checked in early emough to get into the nightly build. 
> Leaving status as is. I'll check again with tomorrows build. Was the other issue
> was corrected at the same time?

	Ria Klaassen (not reading all bugmail) Reporter
	Comment 20 • 19 years ago

(In reply to comment #18)

I had filed this bug especially for this problem. There were never crashes
involved. See comment #0. It still continues in branch build 1.8b4_2005082521.
The error is gone, but the problem continues.

	Ria Klaassen (not reading all bugmail) Reporter
	Comment 21 • 19 years ago

Reopening. Problem in WindowsXP:

When I open the Add Bookmark dialog, I see under the left arrow two choices:
"Bookmarks Toolbar" and "Bookmarks Toolbar folder". One of them is superfluous.
In trunk both choices work; they place the new bookmark in the Bookmarks Toolbar
Folder.
In branch only the choice "Bookmarks Toolbar Folder" works.
Choosing "Bookmarks Toolbar" does nothing.

	Peter van der Woude [:Peter6]
	Comment 22 • 19 years ago

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050826
Firefox/1.0+ ID:2005082604

1. I can't generate any JSC errors
2. I can add a bookmark in both "Bookmarks" entries
3. I can add a bookmark in both "Bookmarks Toolbar" and "Bookmark Toolbar Folder"
4. The drop widget properly adds and removes the New Folder button

What is supposed to fail ?

(ps. have you tried in -safemode ?)

	Tracy Walker [:tracy]
	Comment 23 • 19 years ago

(In reply to comment #15)
> This isn't fixed on the branch as seen on Linux build 2005-08-25-05-mozilla1.8 
> Also, now the default selected "Bookmarks" selection in the Add Bookmarks dialog
> doesn't work.  However, the other "Bookmarks" item below the seperator does work.
> 
> This may not have ben checked in early emough to get into the nightly build. 
> Leaving status as is. I'll check again with tomorrows build. Was the other issue
> was corrected at the same time?

As I suspected, the fix wasn't checked in in time to make yesterdays builds.  As
seen with Linux DP 2005-08-26-05-mozilla1.8 this is working as expected. The
"Bookmarks" selection is fine as well.

	Ria Klaassen (not reading all bugmail) Reporter
	Comment 24 • 19 years ago

The bug is fixed in this build: 1.8b4_2005082604.
Problem resolved.

	Tracy Walker [:tracy]
	Comment 25 • 19 years ago

marking verified per comments 22 and 24

	Tracy Walker [:tracy]
	Comment 26 • 19 years ago

verified on Firefox 1.4 -mozilla1.8 branch- Win, Lin and Mac : 2005-09-07