Closed
Bug 304755
Opened 19 years ago
Closed 18 years ago
[Mac] Error: Warning: unrecognized command line flag -psn_0_14942209
Categories
(Toolkit :: Startup and Profile System, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: jaas)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mark
:
review+
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
Mac OS X 10.4.2
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20050815
Firefox/1.0+
Jesse: i get this a lot during startup in my javascript console:
Jesse: Error: Warning: unrecognized command line flag -psn_0_14942209
Jesse: Source File: ...
/DeerPark.app/Contents/MacOS/components/nsBrowserContentHandler.js
Jesse: Line: 491
cygmonkey: Jesse: that's from osx
cygmonkey: someone should make the handler ignore psn
Reporter | ||
Comment 1•19 years ago
|
||
From https://trac.videolan.org/vlc/file/trunk/src/misc/configuration.c:
/* When vlc.app is run by double clicking in Mac OS X, the 2nd arg
* is the PSN - process serial number (a unique PID-ish thingie)
* still ok for real Darwin & when run from command line */
Reporter | ||
Updated•19 years ago
|
Summary: Error: Warning: unrecognized command line flag -psn_0_14942209 → [Mac] Error: Warning: unrecognized command line flag -psn_0_14942209
Comment 2•19 years ago
|
||
Hrm, I was sure that it was being removed somewhere in
http://lxr.mozilla.org/mozilla/source/toolkit/xre/nsCommandLineServiceMac.cpp
but I can't find it now. It should probably be removed in
nsMacCommandLine::Initialize.
1.8branch reproduces.
Mac OS X 10.3.9
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b5) Gecko/20050922
Firefox/1.4
Comment 4•19 years ago
|
||
*** Bug 317874 has been marked as a duplicate of this bug. ***
Comment 5•19 years ago
|
||
Slight variation on this, note different line number - Javascript Console:
-------
Error: Warning: unrecognized command line flag -psn_0_22020097
Source File: file:///Applications/Browsers/Firefox.app/Contents/MacOS/components/nsBrowserContentHandler.js
Line: 511
---------
OS 10.3.
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Comment 6•19 years ago
|
||
*** Bug 335596 has been marked as a duplicate of this bug. ***
Comment 7•18 years ago
|
||
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20060506 BonEcho/2.0a1
The error still exists in the 2.0 branch, pre-alpha 2 build :
Error: Warning: unrecognized command line flag -psn_0_1441793
Source File: file:///Applications/BonEcho.app/Contents/MacOS/components/nsBrowserContentHandler.js
Line: 520
Comment 8•18 years ago
|
||
*** Bug 316503 has been marked as a duplicate of this bug. ***
*** Bug 357565 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 10•18 years ago
|
||
Attachment #243194 -
Flags: review?(mark)
Comment 11•18 years ago
|
||
Comment on attachment 243194 [details] [diff] [review]
fix v1.0
+ if (!(strlen(flag) >= 4 && strncmp(flag, "-psn", 4) == 0))
You don't need the strlen check, strncmp will stop at a 0-byte.
I'd add one more character and look for "-psn_".
Attachment #243194 -
Flags: review?(mark) → review+
Comment 12•18 years ago
|
||
Comment on attachment 243194 [details] [diff] [review]
fix v1.0
sr=pink
Attachment #243194 -
Flags: superreview+
Assignee | ||
Comment 13•18 years ago
|
||
fixed on trunk
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 15•18 years ago
|
||
This bug seems to be still there, in Firefox 2.0.0.1
Reporter | ||
Comment 16•18 years ago
|
||
That's not surprising, since it was only fixed on trunk (well after the 1.8 branch).
Updated•16 years ago
|
Product: Firefox → Toolkit
Comment 18•16 years ago
|
||
Gee, originally reported in 2005 and finally RESOLVED FIXED in 2008, more than 3 years later! But in which version of Firefox has this been fixed?
Comment 19•16 years ago
|
||
(In reply to comment #18)
> Gee, originally reported in 2005 and finally RESOLVED FIXED in 2008, more than
> 3 years later! But in which version of Firefox has this been fixed?
From the comments it is fixed in the Firefox 3.0 release as was landed on 2006-10-23 08:08:30 PDT per comment #13.
btw: this bug just fixes a warning that didn't cause any problems with functionality.
Comment 20•16 years ago
|
||
Robert, saying "fixed on truck" doesn't say which branch(es) finally got the fix.
Comment 21•16 years ago
|
||
Dick, it isn't all that easy to understand what is going on at times especially if you haven't been around the Mozilla projects a lot. Per the comments, this was never fixed on a branch and it was landed on the trunk on 2006-10-23 08:08:30 PDT which was after the Firefox 2.0 release and that trunk became Firefox 3.0. Also, if this was ever landed on a branch it would have a fixedx.x.x.x or verifiedx.x.x.x keyword where the x.x.x.x is the Gecko version number.
You need to log in
before you can comment on or make changes to this bug.
Description
•