Closed Bug 306131 Opened 19 years ago Closed 14 years ago

SVG attribute parsing abuses strings/chars

Categories

(Core :: SVG, defect)

Product:
Core
Component:
SVG
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: jruderman, Unassigned)

Details

nsSVGPathSegList::SetValueString and nsSVGLength::SetValueAsString (and perhaps others) convert nsAStrings to char* using ToNewCString (http://lxr.mozilla.org/mozilla/source/xpcom/string/public/nsReadableUtils.h#93). This is incorrect because it chops non-ASCII characters and can lead to embedded nulls being treated as the end of the string.
Flags: blocking1.9a1?
Flags: blocking1.9a1? → blocking1.9-
OS: Mac OS X → All
Hardware: Macintosh → All
Version: 1.8 Branch → Trunk
Assignee: general → nobody
QA Contact: ian → general
ToNewCString has gone with the patches that introduced animation. The only remaining content call is in a debug printf.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.