Closed
Bug 306283
Opened 19 years ago
Closed 17 years ago
[FIX]Restore events may not be revoked when a new load happens
Categories
(Core :: DOM: Navigation, defect, P1)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha8
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Biesinger
:
review+
Biesinger
:
superreview+
|
Details | Diff | Splinter Review |
It looks like we only revoke restore events when a STOP_CONTENT Stop() call
happens. Those only happen for the user pressing the "stop" button in the UI,
sets of document.location, setting loading a new URI during paint suppression,
or destruction of the docshell. In particular, normal loads don't explicitly
pass STOP_CONTENT to Stop().
If mContentViewer always has a previous viewer while a restore event is posted,
then we don't really have a problem. Otherwise, we need to deal with revoking
the events on any Stop() call, not just those that have STOP_CONTENT (which
would make more sense to me anyway, to be truthful).
Assignee | ||
Updated•18 years ago
|
Flags: blocking1.9?
Updated•17 years ago
|
Assignee: bryner → bzbarsky
Flags: blocking1.9? → blocking1.9+
Assignee | ||
Comment 1•17 years ago
|
||
Attachment #279136 -
Flags: superreview?(cbiesinger)
Attachment #279136 -
Flags: review?(cbiesinger)
Assignee | ||
Updated•17 years ago
|
Priority: -- → P1
Summary: Restore events may not be revoked when a new load happens → [FIX]Restore events may not be revoked when a new load happens
Target Milestone: --- → mozilla1.9 M8
Updated•17 years ago
|
Attachment #279136 -
Flags: superreview?(cbiesinger)
Attachment #279136 -
Flags: superreview+
Attachment #279136 -
Flags: review?(cbiesinger)
Attachment #279136 -
Flags: review+
Assignee | ||
Comment 2•17 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Component: History: Session → Document Navigation
QA Contact: history.session → docshell
You need to log in
before you can comment on or make changes to this bug.
Description
•