Benjamin Smedberg Assignee
	Description • 19 years ago

Parallels bug 299991, for linux/win.

	Robert Strong (they/them - no direct email)
	Comment 2 • 19 years ago

Sorry but I've been traveling and won't have time to review this properly for
another day.

+    var xulrunnerBinary = getDirectoryKey("XCurProcD");
+    xulrunnerBinary.append("xulrunner-stub@BIN_SUFFIX@");
+
+    xulrunnerBinary.copyTo(aDirectory, appName + "@BIN_SUFFIX@");
When using the appName to create the directory you change it to lowercase -
shouldn't the stub's filename be lowercase as well?

+  BOOL ok = WinLaunchChild(xulBin, argc + 1, argv2);
+
+  free (argv2);
+
+  return !ok;
Returning !ok seems wrong here.

+#else
+  execv(xulBin, argv2);
+
+  return 1;
Why not the result from execv?

	Benjamin Smedberg Assignee
	Comment 3 • 19 years ago

> shouldn't the stub's filename be lowercase as well?
yes

> +  BOOL ok = WinLaunchChild(xulBin, argc + 1, argv2);
> +
> +  free (argv2);
> +
> +  return !ok;
> Returning !ok seems wrong here.

Why? main() traditionally returns "0" for success and error codes for failure.

> Why not the result from execv?

If execv returns we already have a failure condition.

	Robert Strong (they/them - no direct email)
	Comment 4 • 19 years ago

Comment on attachment 199953 [details] [diff] [review]
XULRunner stub for linux/mac, rev. 1

Looks good - only nit I have is making the copy of the stub's name lowercase.

	Benjamin Smedberg Assignee
	Comment 5 • 19 years ago

Fixed, trunk and branch.

	Brian King [:kinger]
	Comment 6 • 19 years ago

Output from launch attempt on Linux. Trunk updated today.

linbrian:/home/mozilla/src/trunk/mozilla/xulrunner-opt-static/dist# bin/xulrunner-bin -install-app /mnt/hda2/mozilla/extensions/xulrunner/cz-xulrunner.xpi
bin/xulrunner-bin: error while loading shared libraries: libxul.so: cannot openshared object file: No such file or directory

	Benjamin Smedberg Assignee
	Comment 7 • 19 years ago

Brian, you still need to use the "xulrunner" script on linux when running xulrunner directly (-install-app for example).

	Brian King [:kinger]
	Comment 8 • 19 years ago

It's working now.