Closed Bug 306893 Opened 19 years ago Closed 19 years ago

Wallpaper patch for better menu appearance in Thunderbird on Windows XP / Luna

Categories

(Thunderbird :: Mail Window Front End, defect)

Product:
Thunderbird
Component:
Mail Window Front End
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME
Milestone:
Thunderbird2.0

People

(Reporter: mozilla, Assigned: mscott)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch v2
(deleted), patch
mscott
: review-
Details | Diff | Splinter Review
Thunderbird version of bug 303806
Mirroring bug 303806's target milestone.
Blocks: 259686
Flags: blocking1.8b4?
Whiteboard: [no l10n impact]
Target Milestone: --- → Thunderbird1.5
not a blocker. Please do not put bugs in milestones for me. Devs and triage teams only should be changing that field.
Flags: blocking1.8b4?
Whiteboard: [no l10n impact]
Target Milestone: Thunderbird1.5 → Thunderbird1.1
*** Bug 308274 has been marked as a duplicate of this bug. ***
Attached patch port changes in menu.css and popup.css (obsolete) (deleted) — — Splinter Review
This should do it
Shayne, I don't think this patch is working quite right. In my test build, when I mouse over the menubar, I get text jiggle amongst the menu bar text items as we make space for the blue selection.
correction, it looks like when I mouse over a menubar item, the selection takes up less width than non selected, so things get moved in, then when i move selection away, the menu bar text nodes get wider.
Shayne, can you help out with a new patch here?
Attachment #195972 - Attachment is obsolete: true
Attached patch Patch v2 (deleted) — — Splinter Review
should do it
Attachment #197987 - Flags: review?(mconnor)
Attachment #197987 - Flags: review?(mconnor) → review?(mscott)
Comment on attachment 197987 [details] [diff] [review] Patch v2 hmm, I still get the same jiggle action in the menu bar with this patch when moving focus over the menu items.
Attachment #197987 - Flags: review?(mscott) → review-
hmm, i ported all the changes from patch 195008, so this sounds like that problem is another issue
on account of them almost done with native theme renderin and on account of all the outcry when somethin like this was landed on firefox, would this be for the best? perhaps hold off until native theme renderin is done.
pushing this off the 1.5 release list since we can't seem to get a patch that works. This should get adddressed without this patch once the xp native theme renderer improvements land anyway.
Target Milestone: Thunderbird1.1 → Thunderbird2.0
now that we use winstripe in toolkit, we are already getting the changes from 303806 so there's nothing left to port here.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: