Closed
Bug 307157
Opened 19 years ago
Closed 19 years ago
Gaps on stretchy characters
Categories
(Core :: MathML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: rbs, Assigned: rbs)
References
()
Details
(Keywords: fixed1.8)
Attachments
(2 files)
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
asa
:
approval1.8b5+
|
Details | Diff | Splinter Review |
(deleted),
image/png
|
Details |
Some gaps occur on stretchy characters. There hit particlarly Linux, or newish
high resolution screens on Windows. I will attach a patch to mitigate these
pixel/roundoff issues. It does the trick for me on Windows on Linux.
Attachment #194978 -
Flags: superreview?(roc)
Attachment #194978 -
Flags: review?(roc)
Comment on attachment 194978 [details] [diff] [review]
patch
@@ -1602,7 +1603,9 @@
// if we are not a largeop in display mode, return if size fits
- if (targetSize <= 0 || (!largeop && IsSizeOK(charSize, targetSize,
aStretchHint))) {
+ if ((targetSize <= 0) ||
+ (!largeop && ((isVertical && charSize >= targetSize) ||
+ IsSizeOK(charSize, targetSize, aStretchHint)))) {
Ops... that bit from bug 306004 crept in here. It is not relevant here.
Attachment #194978 -
Flags: superreview?(roc)
Attachment #194978 -
Flags: superreview+
Attachment #194978 -
Flags: review?(roc)
Attachment #194978 -
Flags: review+
You might want to add a comment that this is a bit of a hack and in the new Gfx
world maybe we can fix this "for real".
It appeared from testing that some of the pieces been glued together have
curved end points (with the tip of the curves possibly rounded off). It is
likely that we will still have to jam these pieces to account for such curves.
That's why I used the non-fixed rulethickness (instead of a fixed amount of
pixels) to jam enough for the curves that are scaling.
Attachment #195072 -
Attachment description: gaps due to curved end points → gaps due to curved end points (screenshot without the patch)
okay. yuck.
Checked in.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment on attachment 194978 [details] [diff] [review]
patch
A similar beautification as bug 306543, but this one is specific to stretchy
MathML characters.
Attachment #194978 -
Flags: approval1.8b5?
Updated•19 years ago
|
Attachment #194978 -
Flags: approval1.8b5? → approval1.8b5+
Comment 9•18 years ago
|
||
This checkin caused bug 321994
Assignee | ||
Comment 10•18 years ago
|
||
Apparently not. I have track that bug down to --enable-pango (unless this checkin awoke something else in pango. you never know...).
You need to log in
before you can comment on or make changes to this bug.
Description
•