Closed
Bug 307340
Opened 19 years ago
Closed 19 years ago
[Mac] Disable "Full Screen" UI for 1.5
Categories
(Firefox :: General, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox1.5
People
(Reporter: asaf, Assigned: asaf)
References
Details
(4 keywords)
Attachments
(1 file)
(deleted),
patch
|
beltzner
:
review+
mconnor
:
superreview+
chase
:
approval1.8b4-
asa
:
approval1.8b5+
|
Details | Diff | Splinter Review |
Our full screen support on OS X has some issues which make it almost useless: * This is not a real full screen mode, the window is "over-maximized" instead. * The window goes under the dock. * Parts of the window go offscreen. We are not going to fix any of those for 1.5.
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → Firefox1.5
Assignee | ||
Comment 1•19 years ago
|
||
Also removed the tip about Opt+Home on mac although it might work for some users (we didn't yet #ifdef the Home keyboard shortcut on mac)
Attachment #195145 -
Flags: superreview?(mconnor)
Attachment #195145 -
Flags: review?(mike)
Assignee | ||
Comment 2•19 years ago
|
||
Comment on attachment 195145 [details] [diff] [review] patch (UI and Help) (I didn't #ifdef the fullscreen code in browser.js, mainly in order to make a possible extension easier).
Assignee | ||
Updated•19 years ago
|
Flags: blocking1.8b5?
Comment 3•19 years ago
|
||
Comment on attachment 195145 [details] [diff] [review] patch (UI and Help) r=me, this should also be noted in the release notes
Attachment #195145 -
Flags: superreview?(mconnor) → superreview+
Assignee | ||
Updated•19 years ago
|
Comment 4•19 years ago
|
||
Comment on attachment 195145 [details] [diff] [review] patch (UI and Help) I'd originally thought "but what about kiosk mode users" until I got a friend's Mac to see what full screen looked like. :) r=me
Attachment #195145 -
Flags: review?(mike) → review+
Assignee | ||
Comment 5•19 years ago
|
||
Comment on attachment 195145 [details] [diff] [review] patch (UI and Help) Better to get this kind of UI change for the first beta.
Attachment #195145 -
Flags: approval1.8b5?
Attachment #195145 -
Flags: approval1.8b4?
Assignee | ||
Updated•19 years ago
|
Flags: blocking1.8b4?
Assignee | ||
Comment 6•19 years ago
|
||
Trunk: mozilla/browser/base/content/browser-menubar.inc,v 1.63 mozilla/browser/base/content/browser-sets.inc 1.56 mozilla/browser/locales/en-US/chrome/help/firebird-toc.rdf 1.39 mozilla/browser/locales/en-US/chrome/help/menu_reference.xhtml 1.34 mozilla/browser/locales/en-US/chrome/help/shortcuts.xhtml 1.38; mozilla/browser/locales/en-US/chrome/help/using_firebird.xhtml 1.31
Comment 7•19 years ago
|
||
we should not respin beta 1 for this. This is not a stop ship bug. Let's take this for beta 2.
Comment 8•19 years ago
|
||
Comment on attachment 195145 [details] [diff] [review] patch (UI and Help) Per triage meeting, not taking for 1.8b4. What l10n impact this patch has we can assume in 1.8b5 when we're ready to take more patches for beta 2.
Attachment #195145 -
Flags: approval1.8b4? → approval1.8b4-
Updated•19 years ago
|
Attachment #195145 -
Flags: approval1.8b5? → approval1.8b5+
Assignee | ||
Comment 10•19 years ago
|
||
1.8 Branch: mozilla/browser/base/content/browser-menubar.inc 1.57.2.6 mozilla/browser/base/content/browser-sets.inc 1.51.2.6 mozilla/browser/locales/en-US/chrome/help/firebird-toc.rdf 1.34.2.4 mozilla/browser/locales/en-US/chrome/help/menu_reference.xhtml 1.31.2.3 mozilla/browser/locales/en-US/chrome/help/shortcuts.xhtml 1.34.4.4 mozilla/browser/locales/en-US/chrome/help/using_firebird. 1.29.2.2
Keywords: fixed1.8
Assignee | ||
Updated•19 years ago
|
Flags: blocking1.8b5?
Comment 11•19 years ago
|
||
Question: are there any plans to actually make full-screen work properly in the post 1.5 version?
Comment 12•19 years ago
|
||
(In reply to comment #11) > Question: are there any plans to actually make full-screen work properly in the post 1.5 version? See bug 307371.
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
Hardware: Macintosh → All
You need to log in
before you can comment on or make changes to this bug.
Description
•