Closed Bug 308045 Opened 19 years ago Closed 19 years ago

fraction line is shifted

Categories

(Core :: MathML, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: rbs, Assigned: rbs)

References

()

Details

(Keywords: fixed1.8)

Attachments

(1 file)

Attached patch fix (deleted) — Splinter Review
Following the general sweep of bug 306543 to improve the inter-spacing, I got feedback from wikipedia folks that it did the trick for them. I am now turning attention to the edge cases. As far I can tell, this patch covers all the remaining tags that need special treatments. It covers <mfrac>, <msqrt>, <mfenced>, which contain things like the fraction line, the sqrt glyph and sqrt bar, or fences and separators that are part of the flow without having frames. [Note: I am aware of the very particular bug 118743. It is quite different and is not my radar in this round.]
Attachment #195683 - Flags: superreview?(roc)
Attachment #195683 - Flags: review?(roc)
I would also like in the course of checkin this patch, to update the spacing table in nsMathMLContainerFrame.cpp as follows: >HERE< /* Ord OpOrd OpInv OpUsr Inner Italic Upright */ - /*Ord */ {0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00}, + /*Ord */ {0x00, 0x00, 0x00, 0x01, 0x01, 0x00, 0x00}, /*OpOrd*/ {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}, /*OpInv*/ {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}, /*OpUsr*/ {0x01, 0x00, 0x00, 0x01, 0x01, 0x01, 0x01}, - /*Inner*/ {0x00, 0x00, 0x00, 0x01, 0x01, 0x00, 0x00}, + /*Inner*/ {0x01, 0x00, 0x00, 0x01, 0x01, 0x01, 0x01}, <<HERE - /*Italic*/ {0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x01}, + /*Italic*/ {0x00, 0x00, 0x00, 0x01, 0x01, 0x00, 0x01}, - /*Upright*/ {0x00, 0x00, 0x00, 0x01, 0x00, 0x01, 0x01} + /*Upright*/ {0x00, 0x00, 0x00, 0x01, 0x01, 0x01, 0x01} <mfrac> is of type 'Inner' on that table. So the change updates its row (resp. column) to also put a thin space before (resp. after) a fraction if it is preceded (resp. followed) by an Ord, Italic, or Upright, MathML frame type.
Blocks: 306543
roc, I will be travelling next week and won't have a chance to follow-up. Would you mind r/sr now so that I can request branch approval?
Attachment #195683 - Flags: superreview?(roc)
Attachment #195683 - Flags: superreview+
Attachment #195683 - Flags: review?(roc)
Attachment #195683 - Flags: review+
Comment on attachment 195683 [details] [diff] [review] fix Remaining piece to go with bug 308045.
Attachment #195683 - Flags: approval1.8b5?
Checked in the trunk.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Attachment #195683 - Flags: approval1.8b5? → approval1.8b5+
Checked in the 1.8 branch.
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: