Closed Bug 30826 Opened 25 years ago Closed 24 years ago

Old style notifications still sent to QA contacts

Categories

(Bugzilla :: Bugzilla-General, defect, P3)

defect

Tracking

()

VERIFIED FIXED
Bugzilla 2.12

People

(Reporter: CodeMachine, Assigned: justdave)

References

()

Details

Attachments

(1 file)

It appears when someone submits a bug to Webtools, I'm getting my QA Contact mail as an old-style notification. When I submit to Webtools, it comes through as new-style.
tara@tequilarista.org is the new owner of Bugzilla and Bonsai. (For details, see my posting in netscape.public.mozilla.webtools, news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)
Assignee: terry → tara
I'm having the same problem. On bugs for which I am the QA contact, I get the old-style notifications. On bugs for which I am the reporter or on the CC list, I get the new style as expected.
Summary: Sometimes getting old-style notifications still. → Old style notifications still sent to QA contacts
If only I could read perl ... this is getting annoying.
OK, Matt, here's the patch you requested. :) Looks like someone just left the poor QA Contact off the list of people that was being dumped to the NewProcessOnePerson routine. The old email tech was picking up the pieces and mailing anyone who hadn't seen it yet. Also in here I removed a duplicate "QA Contact:" field header in the old-style notifications ("QA Contact:" was in the template, but was also being put in the variable that was getting dumped into that field on the template, so it showed up twice).
Thanks, Dave. Tara?
Keywords: patch
Guess I'll take care of this since I can now. :) Tara's way busy at the moment...
Assignee: tara → dave
OK, this has been checked in. It's already been in use on my site for a couple weeks, and seems to be working fine.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
I'm still getting the old-style notifications. Does mozilla.org not use the current CVS version, or what?
Yes, that is correct, mozilla.org does not automatically use the CVS version. It'll be fixed on theirs whenever they get around to doing a cvs update again. I'm not sure who to bug about that, I think they've had some changes in who takes care of what anymore. It might be Gerv... (he'd know who it is if it isn't him).
re-opening this. i just updated bugzilla.mozilla.org to the tip and am getting complaints that bug mail is messed up. Bruce forwarded me a message where the qa contact hadn't changed but since the word "QAContact:" was missing from the output, it showed up as a diff. on the other hand dbaron also saw this in assigned to, so maybe the problem is with some other patch. investigating.... from bruce's mail: -------------------- ! QAContact: chrisd@netscape.com TargetMilestone: M18 URL: Cc: TkThyag@aol.com,akkana@netscape.com,attinasi@netscape.com,bruce@cubik.org,gordon@netscape.com,pierre@netscape.com,warren@netscape.com Summary: leaking documents and webshells while running editor --- 10,18 ---- Component: XP Toolkit/Widgets: XUL AssignedTo: dbaron@fas.harvard.edu ReportedBy: warren@netscape.com ! chrisd@netscape.com
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
See http://bugzilla.mozilla.org/show_activity.cgi?id=21890 , changes at 2000-07-27 16:50:28, for some blank "changed from" fields. Those were in the email blank too...
Yeah, the QA Contact on the OLD email would be from this... it was showing up twice in the original email, but on a change it's missing. Go figure. Put it back how it was. Here's the diff to change that one line back: Index: processmail =================================================================== RCS file: /cvsroot/mozilla/webtools/bugzilla/processmail,v retrieving revision 1.41 diff -u -r1.41 processmail --- processmail 2000/07/13 03:38:30 1.42 +++ processmail 2000/07/28 02:10:30 @@ -191,7 +191,7 @@ my $status_whiteboard = ""; if (Param('useqacontact') && $::bug{'qa_contact'} > 0) { $::bug{'qa_contact'} = DBID_to_name($::bug{'qa_contact'}); - $qa_contact = "$::bug{'qa_contact'}\n"; + $qa_contact = "QAContact: $::bug{'qa_contact'}\n"; } else { $::bug{'qa_contact'} = ""; } (sorry, my server is down right now, so I can't check it in)
Status: REOPENED → ASSIGNED
ok, the "anti-patch" in the previous comment has been checked in. Leaving this open because the original problem it was intended to fix may or may not still be there, and I don't have time to investigate it right now...
OK, I'm going to go ahead and mark this fixed. I had time to investigate finally, and I was seeing things when I thought that was duplicated. It uses it the same way in both places, so it's fine like it now stands.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → FIXED
Verified fixed. All is sweet now, thankyou.
Status: RESOLVED → VERIFIED
Dave, this all looks related to my bug entry (with patch): http://bugzilla.mozilla.org/show_bug.cgi?id=41303 Could you take a look at this and see if it can be checked in?
Dave, this all looks related to my bug entry (with patch): http://bugzilla.mozilla.org/show_bug.cgi?id=41303 Could you take a look at this and see if it can be checked in?
Doesn't look even related, just happens to be a patch against the same file. :) But yeah, if I get some time I'll take a look at that one. Time is the key...
*** Bug 31476 has been marked as a duplicate of this bug. ***
In search of accurate queries.... (sorry for the spam)
Target Milestone: --- → Bugzilla 2.12
Moving closed bugs to Bugzilla product
Component: Bugzilla → Bugzilla-General
Product: Webtools → Bugzilla
Version: other → unspecified
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: