Closed Bug 308754 Opened 19 years ago Closed 17 years ago

The preference binding events (syncfrompreference, synctopreference, change) are fired with wrong JS context

Categories

(Toolkit :: XUL Widgets, defect)

defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: asaf, Assigned: mnyromyr)

References

Details

Attachments

(1 file)

The preference binding events (syncfrompreference, synctopreference, change) are fired with wrong JS context. An example of how can it break stuff is bug 297286 (a similar issue in the colorpicker).
Depends on: 274712
Flags: blocking1.8b5?
Target Milestone: --- → mozilla1.8beta5
Status: NEW → ASSIGNED
Flags: blocking1.8b5?
Target Milestone: mozilla1.8beta5 → mozilla1.9alpha1
Assignee: bugs.mano → nobody
Status: ASSIGNED → NEW
We stumbled upon this during SM pref panel migration.
Assignee: nobody → mnyromyr
Status: NEW → ASSIGNED
Attachment #295295 - Flags: review?
Attachment #295295 - Flags: review? → review?(mconnor)
(In reply to comment #0) > The preference binding events (syncfrompreference, synctopreference, change) > are fired with wrong JS context. As far as I can tell, preference change events have always use standard DOM dispatch with the correct context; for some reason colorpickers are weird because after DOM dispatch they then call their onchange attribute again?! JFTR The preference-specific events don't have automatic handler attributes and therefore we don't use standard DOM dispatch there.
Comment on attachment 295295 [details] [diff] [review] call pseudo event in the context of the actual element Here's hoping Asaf is more accessible on such issues he even filed himself. ;-)
Attachment #295295 - Flags: review?(mconnor) → review?(mano)
Blocks: 411215
Comment on attachment 295295 [details] [diff] [review] call pseudo event in the context of the actual element looks good.
Attachment #295295 - Flags: review?(mano) → review+
Comment on attachment 295295 [details] [diff] [review] call pseudo event in the context of the actual element Low risk; FF/TB/Minimo/Calendar are using global objects/functions to work around the bug and don't care for 'this'.
Attachment #295295 - Flags: approval1.9?
Attachment #295295 - Flags: approval1.9? → approval1.9+
Landed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: