Closed Bug 30971 Opened 25 years ago Closed 23 years ago

cursor: auto does not work

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla0.9.5

People

(Reporter: webmaster, Assigned: pierre)

References

()

Details

(Keywords: css2, Whiteboard: [fix in hand])

Attachments

(2 files)

Mozilla does not support cursor: auto. For example, HTML {cursor: default} INPUT, A, TEXTAREA {cursor: text}, which I use to specify the platform default cursor on all but the user input enabled elements won't work. See the specified URL for detailed a testcase.
This isn't a lyout issue, so changing component to Style System
Assignee: troy → pierre
Component: Layout → Style System
QA Contact: petersen → chrisd
This will depend on bug 1916, "9 Values for the Cursor Property (CSS2) do not work", M15 -- until it is fixed, there will be no way to properly test cursor: auto. See the comment by dbaron@fas.harvard.edu on 1999-10-17 for why.
Depends on: 1916
No longer depends on: 1916
It doesn't depend on 1916 at all. Cursor: auto only requires that those cursors that are used by default are supported. These cursors are: 1. pointer 2. default 3. text All of these are supported so the dependency is wrong.
webmaster@richinstyle.com: That is an incredibly complex test page. Please create a simple test case which is clear, and attach it to this bug report. Thanks.
Keywords: css2
Summary: Cursor: auto does not work → cursor: auto does not work
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Target Milestone: --- → M18
Blocks: 1916
Copying comment from Pierre entered into bug 51113 (relevant to this bug): It seems to me that nsTextFrame::GetCursor() should iterate through all the parents (not just the first one) to find the first one which doesn't have NS_STYLE_CURSOR_AUTO (and if we don't find any, set NS_STYLE_CURSOR_TEXT), a mechanism a little bit similar to what we have for 'cursor-select' in nsFrame::IsSelectable(). When it's done, could you make sure that bug 30971 (cursor: auto does not work) and bug 20080 (cursor: inheritance bug: not inherited inside floated span) are still valid? Thanks.
Block moved M18 bugs to mozilla0.9.1
Target Milestone: M18 → mozilla0.9.1
Netscape's standard compliance QA team reorganised itself once again, so taking remaining non-tables style bugs. Sorry about the spam. I tried to get this done directly at the database level, but apparently that is "not easy because of the shadow db", "plus it screws up the audit trail", so no can do...
QA Contact: chrisd → ian
I had it all wrong in my comments above - and reading the code, I wasn't the only one. Cursor is an inherited property: unlike visibility, we don't need to look at the parents' style. I'll attach a fix and a testcase. Marc, Waterson: please review.
Whiteboard: [fix in hand]
Attached patch fix (deleted) — Splinter Review
Attached file testcase (deleted) —
OK, I see that the text frame is setting the auto cursor to TEXT, but I don't quite understand why the base frame is setting it to DEFAULT. Does that mean that links won't get the hand, or does that get set elsewhere? I'd have to apply the patch and test it, but in this case I trust that you did just that, so [s]r=attinasi.
Sure, I tested it. "cursor:auto" doesn't mean "inherit your parent's cursor" but "set the cursor to whatever is appropriate for you". For a generic frame, the default cursor is, well, 'default' (the arrow). A very few frames override GetCursor(). It's because they set it in the css files, like html.css for the links.
Moving to m0.9.2
Target Milestone: mozilla0.9.1 → mozilla0.9.2
fixed
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
VERIFIED using Pierre's testcase.
Status: RESOLVED → VERIFIED
I think this fix caused bug 88688 per Marc's fear: "Does that mean that links won't get the hand, or does that get set elsewhere?" Can someone verify and re-open this bug or comment in the other bug that this is not the case?
IU backed out Pierre's changes locally and it did not fix the problem with cursor:auto on a link, so I don't think this fix actually regressed it, rather it never worked at all...
Reopening: cursor:auto does not work on a link (anchor). See testcase in bug 88688
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Milestone reality check.
Target Milestone: mozilla0.9.2 → mozilla0.9.4
Target Milestone: mozilla0.9.4 → mozilla0.9.5
Marked fixed again. Bug 88688 is not a regression but a different instance of this bug that was not covered by my patch.
Status: REOPENED → RESOLVED
Closed: 24 years ago23 years ago
Resolution: --- → FIXED
Blocks: 88688
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: