Closed
Bug 309760
Opened 19 years ago
Closed 19 years ago
series.public rename breaks upgrades from 2.17.1
Categories
(Bugzilla :: Installation & Upgrading, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.22
People
(Reporter: mkanat, Assigned: mkanat)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bugreport
:
review+
|
Details | Diff | Splinter Review |
The checksetup tinderbox has informed me that the patch from bug 308717 breaks
upgrades from 2.17.1. The reason is:
The series table is *created* after 2.17.1, and later on in checksetup we try to
rename a column on it that doesn't exist, using bz_alter_column_raw (so it
doesn't actually check the column's existence before renaming).
Since that part of checksetup is a big hack, I'm not going to back out bug
308717, but instead just patch it quickly here.
|
Assignee | |
Updated•19 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.22
|
|
Assignee | |
Comment 1•19 years ago
|
||
It's OK to use bz_column_info in there, when we're just checking if the column
exists or not.
Attachment #197181 -
Flags: review?(bugreport)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 197181 [details] [diff] [review]
Fix upgrades from 2.17.1 by only fixing the column if it exists
r=joel by inspection if you've tested it.
Attachment #197181 -
Flags: review?(bugreport) → review+
|
||
Updated•19 years ago
|
Flags: approval? → approval+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v <-- checksetup.pl
new revision: 1.438; previous revision: 1.437
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•