Closed Bug 310653 Opened 19 years ago Closed 19 years ago

###!!! ASSERTION: Incorrect aDocument: '!aParent || aParent->GetCurrentDoc() == aDocument'

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: WeirdAl, Assigned: peterv)

References

Details

(Keywords: assertion, fixed1.8, testcase)

Attachments

(2 files)

This assertion stems from bug 278472 and bz's checkin to trunk. Testcase coming up in a few moments.
Attached file testcase (deleted) —
bz: fyi, the assertion comes from an element that has been created by the document, but not inserted into the document anywhere.
00 ntdll!DbgBreakPoint 01 xpcom_core!nsDebugImpl::Break+0x7e [m:\mozilla\xpcom\base\nsdebugimpl.cpp @ 350] 02 xpcom_core!nsDebugImpl::Assertion+0x29e [m:\mozilla\xpcom\base\nsdebugimpl.cpp @ 266] 03 xpcom_core!NSGlue_Assertion+0x4d [m:\builds\mozdebug\xpcom\build\nsdebug.cpp @ 107] 04 gklayout!nsGenericElement::doReplaceChild+0x63 [m:\mozilla\content\base\src\nsgenericelement.cpp @ 3416] 05 gklayout!nsGenericElement::ReplaceChild+0x28 [m:\mozilla\content\base\src\nsgenericelement.cpp @ 3019] 06 gklayout!nsXULElement::ReplaceChild+0x18 [m:\mozilla\content\xul\content\src\nsxulelement.h @ 556] ... then it gets into JS land, where: node.replaceChild(secondInsertion, firstInsertion); /* node = document.createElement("box"); firstInsertion = document.createComment("text one"); secondInsertion = document.createComment("text two"); */
Attached patch v1 (deleted) — Splinter Review
Attachment #198131 - Flags: superreview?(bzbarsky)
Attachment #198131 - Flags: review?(bzbarsky)
Blocks: 278472
Attachment #198131 - Flags: superreview?(bzbarsky)
Attachment #198131 - Flags: superreview+
Attachment #198131 - Flags: review?(bzbarsky)
Attachment #198131 - Flags: review+
Attachment #198131 - Flags: approval1.8b5?
Assignee: bzbarsky → peterv
OS: Windows XP → All
Hardware: PC → All
Flags: blocking1.8b5?
Comment on attachment 198131 [details] [diff] [review] v1 a=shaver to fix late-breaking branch regression
Attachment #198131 - Flags: approval1.8b5? → approval1.8b5+
Fixed on trunk and 1.8 branch. Peter, thanks for picking this up!
Status: NEW → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
Flags: blocking1.8b5? → blocking1.8b5+
Component: DOM: Core → DOM: Core & HTML
QA Contact: ian → general
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: