Closed
Bug 310653
Opened 19 years ago
Closed 19 years ago
###!!! ASSERTION: Incorrect aDocument: '!aParent || aParent->GetCurrentDoc() == aDocument'
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: WeirdAl, Assigned: peterv)
References
Details
(Keywords: assertion, fixed1.8, testcase)
Attachments
(2 files)
(deleted),
application/vnd.mozilla.xul+xml
|
Details | |
(deleted),
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
shaver
:
approval1.8b5+
|
Details | Diff | Splinter Review |
This assertion stems from bug 278472 and bz's checkin to trunk. Testcase coming
up in a few moments.
Reporter | ||
Comment 1•19 years ago
|
||
bz: fyi, the assertion comes from an element that has been created by the
document, but not inserted into the document anywhere.
Reporter | ||
Comment 2•19 years ago
|
||
00 ntdll!DbgBreakPoint
01 xpcom_core!nsDebugImpl::Break+0x7e [m:\mozilla\xpcom\base\nsdebugimpl.cpp @ 350]
02 xpcom_core!nsDebugImpl::Assertion+0x29e
[m:\mozilla\xpcom\base\nsdebugimpl.cpp @ 266]
03 xpcom_core!NSGlue_Assertion+0x4d [m:\builds\mozdebug\xpcom\build\nsdebug.cpp
@ 107]
04 gklayout!nsGenericElement::doReplaceChild+0x63
[m:\mozilla\content\base\src\nsgenericelement.cpp @ 3416]
05 gklayout!nsGenericElement::ReplaceChild+0x28
[m:\mozilla\content\base\src\nsgenericelement.cpp @ 3019]
06 gklayout!nsXULElement::ReplaceChild+0x18
[m:\mozilla\content\xul\content\src\nsxulelement.h @ 556]
... then it gets into JS land, where:
node.replaceChild(secondInsertion, firstInsertion);
/*
node = document.createElement("box");
firstInsertion = document.createComment("text one");
secondInsertion = document.createComment("text two");
*/
Assignee | ||
Comment 3•19 years ago
|
||
Attachment #198131 -
Flags: superreview?(bzbarsky)
Attachment #198131 -
Flags: review?(bzbarsky)
Updated•19 years ago
|
Attachment #198131 -
Flags: superreview?(bzbarsky)
Attachment #198131 -
Flags: superreview+
Attachment #198131 -
Flags: review?(bzbarsky)
Attachment #198131 -
Flags: review+
Attachment #198131 -
Flags: approval1.8b5?
Updated•19 years ago
|
Assignee: bzbarsky → peterv
OS: Windows XP → All
Hardware: PC → All
Updated•19 years ago
|
Flags: blocking1.8b5?
Comment on attachment 198131 [details] [diff] [review]
v1
a=shaver to fix late-breaking branch regression
Attachment #198131 -
Flags: approval1.8b5? → approval1.8b5+
Comment 5•19 years ago
|
||
Fixed on trunk and 1.8 branch. Peter, thanks for picking this up!
Updated•19 years ago
|
Flags: blocking1.8b5? → blocking1.8b5+
You need to log in
before you can comment on or make changes to this bug.
Description
•