Closed
Bug 310654
Opened 19 years ago
Closed 10 years ago
font*.properties files are not packaged by the installer
Categories
(Core Graveyard :: GFX: Win32, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: jshin1987, Assigned: jshin1987)
Details
(Keywords: intl)
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Apparently because $(INSTALL) is used instead of $(SYSINSTALL) in Makefile.in in
gfx/src/windows. Two files - fontEncoding.properties and fontName.properties -
are not installed. As a result, mathml is not rendered correctly and CJK native
font name resolution is not done on non-CJK Windows.
Assignee | ||
Comment 1•19 years ago
|
||
this is a trivial patch
Attachment #198185 -
Flags: superreview?(rbs)
Attachment #198185 -
Flags: review?(rbs)
Also check http://lxr.mozilla.org/mozilla/source/gfx/src/windows/gfxwin.pkg
fontNameMap.properties isn't there.
Comment 3•19 years ago
|
||
the *.pkg files aren't used; it is hoped to maybe use them at some point.
you should patch the installer manifests
Comment 4•19 years ago
|
||
(and of course "make install" as patched by this makefile is used by basically
nobody on windows)
Assignee | ||
Comment 5•19 years ago
|
||
Thanks. Which one did you mean
http://lxr.mozilla.org/seamonkey/source/embedding/config/basebrowser-win#269
or
http://lxr.mozilla.org/seamonkey/source/embedding/config/basebrowser-installer-win.pkg#248
You may have meant something else, but I couldn't find any install.js/rdf file
that has fontEncoding.properties.
Comment 6•19 years ago
|
||
the former, although I'm not sure if firefox uses that file.
Comment 7•19 years ago
|
||
oh, so this file is already listed. that means that installers will ship it
already. zip builds ship everything in dist/bin. (in seamonkey's case at least.
not sure what happens for ffox)
Based on comment #7, this bug is invalid then (at least on Seonmomkey). My
initial alarm (on the wake of the Mac problem) was that fontNameMap.properties
isn't in
http://lxr.mozilla.org/mozilla/source/gfx/src/windows/gfxwin.pkg
which I thought was used by the build wizardry. Is that prudent to fix
gfxwin.pkg and the basebrowser-* now?!? (why is that the files are commented out
in one but not the other?) And is there any plan to ever use the pacthed "make
install"?
Assignee | ||
Comment 9•19 years ago
|
||
firefox 1.5beta installed with the installer has both files
(fontEncoding.properties and fontNameMap.properties). So does firefox2005-06-xx
zip. The latter fact seems to indicate that zip file for ff behaves similar to
seamonkey zip (ship everything in dist/bin). I don't understand the former case,
though. fontEncoding.properties is listed but fontNameMap.properties is not
listed in any of 'manifest' and pkg files(although pkg files are not used), but
still both are included in firefox 1.5beta1.
Is there any harm if we add fontNameMap.properties to two files in
embedding/config and gfxwin.pkg now? It'd only makes us future-proof, wouldn't it?
I'm downgrading to 'trivial' (instead closing as invalid) because we may need to
list fontNameMap.properties in those files to be future-proof.
Severity: normal → trivial
Comment 10•19 years ago
|
||
The firefox manifest is located at
http://lxr.mozilla.org/mozilla/source/browser/installer/windows/packages-static#254
and ships everything in dist/bin/res/fonts. This manifest is used for both
installer and tarball (zip) builds on windows, and there is a matching manifest
for unix. Mac currently does not use a manifest.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → WORKSFORME
Comment 11•19 years ago
|
||
hrm, fontNameMap.properties isn't listed in any seamonkey installer manifest
files, is it?
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Comment 12•19 years ago
|
||
jshin, what is the status of the patch? In the light of the other comments made later (such as comment #4), do you still want me to r+sr?
Updated•16 years ago
|
Product: Core → Core Graveyard
Comment 13•10 years ago
|
||
This bug has been buried in the graveyard and has not been updated in over 5 years. It is probably safe to assume that it will never be fixed, so resolving as WONTFIX.
[Mass-change filter: graveyard-wontfix-2014-09-24]
Status: REOPENED → RESOLVED
Closed: 19 years ago → 10 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•