Closed
Bug 311208
Opened 19 years ago
Closed 19 years ago
goButtonObserver incorrectly passes a nsURI to dragDropSecurityCheck (dragging a link to the "Go" button doesn't work)
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: Gavin, Assigned: dveditz)
References
()
Details
(Keywords: fixed1.8, regression, Whiteboard: [sg:nse])
Attachments
(1 file)
|
(deleted),
patch
|
mconnor
:
review+
asa
:
approval1.8rc1+
|
Details | Diff | Splinter Review |
The checkin for bug 291651 broke the go button onDrop handler by making it pass
in a nsURI instead of just the url string. dragDropSecurityCheck expects a URL
string and makes it's own nsURI, so this throws.
This isn't really a security issue, just broken behavior, since it's a case of
throwing when it shouldn't, but I'm marking this security sensitive only because
bug 291651 still is. Please make it open to the public if that is not an issue.
|
Assignee | |
Comment 1•19 years ago
|
||
This is simple and ought to be fixed.
|
|
Assignee | |
Comment 2•19 years ago
|
||
fixes regression
Attachment #198601 -
Flags: review?(mconnor)
Attachment #198601 -
Flags: approval1.8b5?
|
||
Comment 3•19 years ago
|
||
we'll get this in rc1
Flags: blocking1.8rc1+
Flags: blocking1.8b5?
Flags: blocking1.8b5-
|
|
Assignee | |
Updated•19 years ago
|
Attachment #198601 -
Flags: approval1.8b5? → approval1.8rc1?
|
||
Updated•19 years ago
|
Attachment #198601 -
Flags: review?(mconnor) → review+
|
|
||
Updated•19 years ago
|
Attachment #198601 -
Flags: approval1.8rc1? → approval1.8rc1+
|
|
Assignee | |
Comment 4•19 years ago
|
||
fix checked into trunk and 1.8 branch
You need to log in
before you can comment on or make changes to this bug.
Description
•