in RTL interface the start page doesn't take RTL direction. steps to reproduce: 1. download RTL build from: ftp://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-mozilla1.8-l10n/thunderbird-1.4.1.he.win32.zip 2. open Thunderbird and look at the start page.

adding the files to messenger.jar. the image files go in mozilla/mail/base/content

Comment on attachment 198948 [details] [diff] [review] adding RTL support to start.xhtml > ul { > margin-left: 30px; > padding-left: 0px; > line-height: 1.2em; > } > >+body[dir="rtl"] ul { >+ margin-right: 30px; >+ padding-right: 0px; >+ line-height: 1.2em; >+} >+ Try the following style rule instead of the two: ul { -moz-margin-start: 30px; -moz-padding-start: 0px; line-height: 1.2em; } r=mano with that fixed; needs moa from mscott.

Comment on attachment 198614 [details] [diff] [review] adding the files to jar.mn r=mano

(In reply to comment #4) > Try the following style rule instead of the two: > ul { > -moz-margin-start: 30px; > -moz-padding-start: 0px; > line-height: 1.2em; > } doesn't seem to have any affect...

Comment on attachment 198948 [details] [diff] [review] adding RTL support to start.xhtml Mano's CSS suggestion should work and is the right way to do this. I'm going to check this in as is for now but if you could figure out why his suggestion did not work for you, I would appreciate it. Thanks.

fixed on the trunk

Scott, can this go on the branch?

(In reply to comment #9) > Scott, can this go on the branch? Once we get the RTL theme squared away on the branch, then yes :)

(In reply to comment #7) > (From update of attachment 198948 [details] [diff] [review] [edit]) > Mano's CSS suggestion should work and is the right way to do this. I'm going > to check this in as is for now but if you could figure out why his suggestion > did not work for you, I would appreciate it. Thanks. > moz-margin and moz-padding are styles unique to the xul language and are not part of Html or Xhtml.

That's is a false assertion, see the way we use it in html.css for lists. <snaky>CSS isn't a part (x)html.</snaky>

(In reply to comment #12) > That's is a false assertion, see the way we use it in html.css for lists. > > <snaky>CSS isn't a part (x)html.</snaky> still doesn't seem to have any effect... is it possible it's not applies in xhtml (not html)?

Reuven, how is this looking on the trunk now that it's all checked in? We don't have the ability to verify these changes ourselves, we need your help.

O.K forgive me, this looks like my own mess up. the moz-margin does work, but for some reason i didn't add the '-' before the moz-margin-side :-\ i will attach a fix for this soon. mscott: the start page currently looks good in both directions.

this patch uses the -moz-margin-start(end) instead of margin-right(left) for the margins and paddings.

this patch uses the moz styles with the branding rtl image (thunderbird-watermark-rtl) removed.

oops... we still need to align the watermark to the left in RTL interface.

Comment on attachment 200193 [details] [diff] [review] as above, fixing the watermark location r=mano

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).