Closed
Bug 31131
Opened 25 years ago
Closed 24 years ago
Bounding box updating makes scrolling/page loading slow
Categories
(Core :: XUL, defect, P1)
Tracking
()
VERIFIED
FIXED
M16
People
(Reporter: pierre, Assigned: mikepinkerton)
References
Details
(Keywords: perf, platform-parity, Whiteboard: [dogfood-][nsbeta2+][6/15] fix in hand)
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Tested on today's build on the Mac (WinNT doesn't show the problem).
- Go to the Tinderbox page
- Click the down arrow of the vertical scrollbar and wait until you scroll to the
bottom of the page
==> It takes about 18 seconds on a G4/450
- Turn off GFXScrollBars in the Debug prefs
- Repeat the test above
==> It takes about 5.5 seconds (more than 3 times faster)
Comment 1•25 years ago
|
||
assigning to evaughan as p3 for m15.
Assignee: trudelle → evaughan
Target Milestone: M15
Assignee | ||
Comment 2•25 years ago
|
||
*** This bug has been marked as a duplicate of 24956 ***
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → DUPLICATE
Reporter | ||
Comment 3•25 years ago
|
||
Reopening. Bug 24956 describes a difference of speed between Moz and Nav4x on all
platforms while this bug (31131) describes a difference of speed between GFX and
Native scrollbars on the Mac. I tested on Windows: it scrolls at the same speed
with and without GFX scrollbars.
On the Mac, if it wasn't for the scrollbars, this bug shows that Moz could scroll
3 times faster but then even we we fix it, we may very well still scroll twice as
slow as Nav, as described in bug 24956.
Comment 4•25 years ago
|
||
*** This bug has been marked as a duplicate of 29840 ***
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → DUPLICATE
Reporter | ||
Comment 5•25 years ago
|
||
Reopening again. This is not about a difference of speed between Moz and Nav. It
is about a difference of speed between Moz-with-native-scrollbars and Moz-with-
GFX scrollbars on the Mac. It is a platform-specific problem.
We know that on all platforms Moz is much slower than Nav, as described in bug
24956, bug 29840 (which are dups, I believe) and maybe other ones too. The
present bug shows that native scrollbars, on the Mac only, cause an additional
and serious slowdown. Paint Flashing in the Debug prefs may give an idea of
what's going on.
Eric- If you don't do Mac, you may have to reassign to a volunteer in the Mac
team (pink, beard, sfraser).
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
See also bug 33602. Never paid attention before but I believe 33602
might be a dup of this one as symptoms described in it
diminish/disappear with Gfx scrollbars turned off.
Reporter | ||
Comment 8•25 years ago
|
||
Nothing to do with 33602 but as evaughan wrote, this is indeed a dup of bug
29640. Scrolling is slower with gfx scrollbars because
nsScrollbarButtonFrame::MouseClicked() sets the nsXULAtoms::curpos attribute,
which causes a reflow (while with native scrollbars, we just send a
NS_SCROLLBAR_LINE_NEXT message to the scrollview and everything's fine).
I'm reassigning this bug to myself to investigate the Mac specific part: why is
the reflow so much slower on the Mac than on Windows?
Assignee: evaughan → pierre
Status: REOPENED → NEW
Summary: Mac-GFXScrollbars make scrolling 3 times slower → [PERF]Mac-GFXScrollbars make scrolling 3 times slower
Target Milestone: M16 → M20
Reporter | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Comment 10•25 years ago
|
||
Copying this comment in from 29840 because this bug is where this comment really
belongs. Adding lordpixel to cc: list.
------- Additional Comments From lordpixel@mac.com 2000-04-27 18:04 -------
In a sense this comment is just noise, but I have to say this is probably my
number one issue with GFX scrollbars on the Mac.
They're slow as molasses on a G4 400MHz so I can only imagine what they're like
on a slow machine (unless its purely a throttling issue).
This is with view manager 2. Switching back to native scrollbars cures the
problem.
Assignee | ||
Comment 11•24 years ago
|
||
taking it over.
I have a fix for slow gfx-scrolling and page loading by picking apart the non-
rectangular update region and not using it as a bounding box, but sending
multiple paint events for each small rect.
scrolling is now _MUCH_ faster, as are page loads since we no longer redraw the
entire previous page before loading the next one.
Assignee: pierre → pinkerton
Severity: normal → critical
Status: ASSIGNED → NEW
Keywords: dogfood
Priority: P3 → P1
Summary: [PERF]Mac-GFXScrollbars make scrolling 3 times slower → [PERF] Bounding box updating makes scrolling/page loading slow
Whiteboard: fix in hand
Target Milestone: M20 → M16
Comment 12•24 years ago
|
||
This really stops me from using the Mac product, also nominating for nsbeta2 so
we can get a [mm/dd] window for checkin.
Keywords: nsbeta2
Updated•24 years ago
|
Summary: [PERF] Bounding box updating makes scrolling/page loading slow → Bounding box updating makes scrolling/page loading slow
Assignee | ||
Comment 13•24 years ago
|
||
Reporter | ||
Comment 14•24 years ago
|
||
Pink: I don't know what the RepeatService is for but are you sure you want on
platforms other than the Mac to have a REPEAT_DELAY much longer than the
INITAL_REPEAT_DELAY? It used to be the opposite.
Assignee | ||
Comment 15•24 years ago
|
||
my bad, you're right. i'll fix that. thanks pierre!
Assignee | ||
Comment 16•24 years ago
|
||
accepting to avoid those silly reminder messages from terry.
Status: NEW → ASSIGNED
Comment 18•24 years ago
|
||
[dogfood-]
QA Contact: jrgm → jefft
Whiteboard: [nsbeta2+][6/15] fix in hand → [dogfood-][nsbeta2+][6/15] fix in hand
Assignee | ||
Comment 19•24 years ago
|
||
file this one to netscape.public.mozilla.slow.mac.builds.die.die.die
fixed.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 24 years ago
Resolution: --- → FIXED
Comment 20•24 years ago
|
||
verifying
scrolling test on tinderbox page took 12 secs without gfx scrollbars
it took 8 secs with gfx scrollbars
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•