There is a directoryservice key that looks like it should be this, but it actually points to "Programs" in the Start menu.

Comment on attachment 198694 [details] [diff] [review] Add dirservice key, rev. 1 r=darin It's a shame that these windows specific directory service keys are not prefixed with "Win" or something like that.

Fixed on trunk.

Comment on attachment 198694 [details] [diff] [review] Add dirservice key, rev. 1 I'd like this for xulrunner for the nsXULAppInstall implementation, it's very low-risk since it's adding a new key and I'm using the same codepaths that are already used.

This causes build bustage where CSIDL_PROGRAM_FILES is not defined, exactly as in bug 241282 comment 22 and following

smontagu, I'm traveling today and won't have checkin capabilities till this afternoon, can you land an equivalent patch to the one in bug 241282?

No problem. This is the patch I made in my own tree.

Checked in the bustage fix.

please tell us why we need this and if it could possibly have any negative impact on our primary apps. Also, is it really windows95 only?

No, this patch is all-windows, the build fix that smontagu created is for old windows SDKs that don't define the proper constant. The risk is minimal (except for the build bustage which was fixed) since nobody except XULRunner will be using this key. The reason I want this patch for 1.8 is so that XULRunner knows that windows apps belong by default in C:\Program Files (bug 300139).