Closed Bug 312205 Opened 19 years ago Closed 16 years ago

Bookmark menu items are taller than other menu items

Categories

(Firefox :: Menus, defect)

1.5.0.x Branch
x86
Windows XP
defect
Not set
trivial

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: nnbugzilla, Unassigned)

Details

Attachments

(2 files)

Bookmark this page is 14 pixels high, while a bookmark item is about 21 pixels. I'm guessing this is due to patch for bug 243078 (native theme rendering).
Attached image Regular menu item (14 pix high) (deleted) —
Attached image Bookmark menu item (21 pix) (deleted) —
James, when you're back can you look into this?
It is expected the bookmark items will be bigger, as resizing the bookmark icons from their existing size was deemed bad. If it isn't forcing the favicons, that's a different issue.
James, you're right. But on an older build of Firefox branch (with the Classic Menu extension), the difference in menu item heights doesn't seem to be as great. It's also possible that the vertical alignment (closer to top instead of centered) makes this look worse. However, I should also point out that all menu items are the same height in standard Windows apps. In any case, I'll wait until the vertical alignment issues have settled and see how that affects this.
The consitency of height is a fundamental problem with the XUL menu system. In a Windows app, it knows if it uses images - and their size - so can make *all* menus bigger than the Windows' settings to accomodate the images (some apps will do this for only the items within a menu with images, others do it for all menus in the app). XUL can not do this (without a lot of re-working and code), and so you always have the issue of items with images that make them bigger than the 'normal' size. If you ever installed CuteMenus, you may have seen this problem previously (it was fairly subtle before the changes, as menu items were bigger).
I can't tell from the discussion whether this should be resolved as WONTFIX, or is an actual bug that should be fixed. Either way, though, there hasn't been any comment on it in over 3 years. Any updates?
Whiteboard: [closeme 2009-04-15 WONTFIX?]
Neil, that shouldn't be a problem anymore, right? At least I cannot see it visually but I don't know about anything about the underlying stuff.
No action has been taken in the past month, so I'm marking this as WONTFIX, as per comment 8.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → WONTFIX
Whiteboard: [closeme 2009-04-15 WONTFIX?]
It's not up to you to decide its wontfix. Setting as WFM since no-one was able to see this with the latest versions.
Resolution: WONTFIX → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: