Closed
Bug 312980
Opened 19 years ago
Closed 19 years ago
Use classes instead of pseudo elements
Categories
(Core Graveyard :: XForms, defect)
Core Graveyard
XForms
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: allan, Assigned: allan)
References
()
Details
(Keywords: fixed1.8.0.2, fixed1.8.1)
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Until bug 271724 is fixed, I think we should put f.x. a class="xf-value" on the
value elements, and also change @repeat-index to a class instead.
|
Assignee | |
Comment 1•19 years ago
|
||
* sets the class "xf-value" (should be ::value) on elements where it makes sense
* changes nsXFormsContentContainer to use @class too, and also sets "repeat-item" class (which should be ::repeat-item)
Attachment #200778 -
Flags: review?(doronr)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 200778 [details] [diff] [review]
Patch
>
> <!-- UPLOAD: DISABLED -->
> <binding id="xformswidget-upload-disabled"
> extends="chrome://xforms/content/xforms.xml#xformswidget-base">
> <content>
> <children includes="label"/>
> <html:input readonly="true"
>+ class="value"
you want xf-value probably!
Attachment #200778 -
Flags: review?(doronr) → review-
|
|
Assignee | |
Comment 3•19 years ago
|
||
(In reply to comment #2)
> (From update of attachment 200778 [details] [diff] [review] [edit])
> >
> > <!-- UPLOAD: DISABLED -->
> > <binding id="xformswidget-upload-disabled"
> > extends="chrome://xforms/content/xforms.xml#xformswidget-base">
> > <content>
> > <children includes="label"/>
> > <html:input readonly="true"
> >+ class="value"
>
> you want xf-value probably!
No! I _hate_ upload. It should be punished! Take that you lousy control!
... or yes :-)
Attachment #200778 -
Attachment is obsolete: true
Attachment #200779 -
Flags: review?(doronr)
|
|
||
Updated•19 years ago
|
Attachment #200779 -
Flags: review?(doronr) → review+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #200779 -
Flags: review?(smaug)
|
||
Comment 4•19 years ago
|
||
Comment on attachment 200779 [details] [diff] [review]
Patch v2
> */
> NS_IMETHODIMP
> nsXFormsContextContainer::SetIndexState(PRBool aHasIndex)
> {
> if (mElement) {
>- NS_NAMED_LITERAL_STRING(repIndex, "repeat-index");
>+ mHasIndex = aHasIndex;
>+ NS_NAMED_LITERAL_STRING(classStr, "class");
> if (aHasIndex) {
>- mElement->SetAttribute(repIndex,
>- NS_LITERAL_STRING("1"));
>+ mElement->SetAttribute(classStr,
>+ NS_LITERAL_STRING("repeat-item repeat-index"));
> } else {
>- mElement->RemoveAttribute(repIndex);
>+ mElement->SetAttribute(classStr, NS_LITERAL_STRING("repeat-item"));
> }
xf-repeat-item and xf-repeat-index
With those, r=me
Attachment #200779 -
Flags: review?(smaug) → review+
|
|
Assignee | |
Comment 5•19 years ago
|
||
Attachment #200779 -
Attachment is obsolete: true
checked into MOZILLA_1_8_BRANCH via bug 323691. Leaving open for now until it gets into 1.8.0
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: xf-to-branch
|
|
Assignee | |
Updated•19 years ago
|
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•