Closed Bug 313918 Opened 19 years ago Closed 19 years ago

IME candidate list is positioned to wrong position if the caret is positioned non-root view

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

(4 keywords)

Attachments

(4 files, 2 obsolete files)

If the editor is positioned non-root view(e.g., the option dialog of Firefox/Thunderbird and the Edit Card dialog of Address Book), the IME candidate list window is positioned wrong position.
Attached patch Patch rv1.0 (obsolete) (deleted) — Splinter Review
We need to test this patch on non Windows OS.
Bezilla staff: This patch is changing the XP IME event's reply values. Could you test this patch on BeOS?
Status: NEW → ASSIGNED
Attached patch Patch rv1.1 (obsolete) (deleted) — Splinter Review
Oops... Sorry. Previous patch is not enough.
Attachment #200893 - Attachment is obsolete: true
I couldnt' reproduce this bug at BeOS, with native IME dialog btw. May test those changes when new build is finished, but most probably at coming weekend
Comment on attachment 200898 [details] [diff] [review] Patch rv1.1 Ah... This patch is wrong. I'll create new patch.
Attachment #200898 - Attachment is obsolete: true
Attachment #200898 - Flags: review-
Attached patch Patch rv2.0 (deleted) — Splinter Review
This patch is "adhoc". But we select this way in bug 59405. Because, if we select the best way, we need very large change for this bugs. But this adhoc way makes very small change for us.
Attachment #201116 - Flags: superreview?(roc)
Attachment #201116 - Flags: review?(roc)
Bezilla staff: The new patch changes only Windows code. Thanks.
Attachment #201116 - Flags: superreview?(roc)
Attachment #201116 - Flags: superreview+
Attachment #201116 - Flags: review?(roc)
Attachment #201116 - Flags: review+
checked-in. Thank you roc!
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Momoi-san(Google) reported that this bug can be reproduced with new chat form on Gmail. And I confirmed it, and the patch for this bug and bug 315457 can fix the bug. We should land the patches to 1.8 branch.
This patch is merged the patch for this bug (attachment 201116 [details] [diff] [review]) and the patch for bug 315457 which is regression of this bug (attachment 202190 [details] [diff] [review]). The patches are already working fine on trunk during a long term. r+sr are carried over from the original patches, this patch is not changed anything from them.
Attachment #287316 - Flags: superreview+
Attachment #287316 - Flags: review+
Attachment #287316 - Flags: approval1.8.1.10?
Flags: blocking1.8.1.10?
Whiteboard: we can reproduce this bug with the chat form of Gmail with Fx2
Thanks Nakano-san for proposing to down integrate the fix into the 1.8 branch. Google products have a fairly large number of Firefox 2 users. This bug severely affects Chinese and Japanese users of the following products: 1. Gmail (new UI) that went out last week to some users and will be going to all Gmail users shortly. * Non-detached chat window at bottom right * Address Book - Name input field for a new entry 2. Google Spreadsheet: current version at docs.google.com * All cell input 3. Google Presentation: current version at docs.google.com * Link text input window There are likely to be other products with the same problem -- wherever there is a non-root window. Please get this in asap for the IME users in these countries. Thanks!
Comment on attachment 287316 [details] [diff] [review] Patch for 1.8 branch (attachment 201116 [details] [diff] [review] and attachment 202190 [details] [diff] [review]) approved for 1.8.1.10, a=dveditz for release-drivers
Attachment #287316 - Flags: approval1.8.1.10? → approval1.8.1.10+
checked-in.
Flags: blocking1.8.1.11?
Keywords: fixed1.8.1.10
Whiteboard: we can reproduce this bug with the chat form of Gmail with Fx2
Masayuki, can you check with the Firefox 2.0.0.10 release candidate at http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2.0.0.10-candidates/rc1/ and verify that this is fixed?
-> v. on 1.8.1.10
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: