Closed
Bug 314148
Opened 19 years ago
Closed 15 years ago
software update happily updates even if another instance of firefox is running
Categories
(Toolkit :: Application Update, defect, P2)
Tracking
()
RESOLVED
DUPLICATE
of bug 525390
People
(Reporter: vlad, Assigned: robert.strong.bugs)
References
Details
In the case of two or more firefox instances started from the same binary but with different profiles, if any one of those does a software update, the updater app will happily do its thing thus causing massive problems for the other running instances. There really needs to be some sort of lock in the application directory or something similar to indicate that there are no firefox instances running. This isn't super high priority since it requires multiple profiles to be in use, but the same would happen for a shared install of firefox.
Comment 1•19 years ago
|
||
I've seen this on Linux too.
The Windows installer has code to shut down other instances, which might be useful on that platform.
OS: Windows XP → All
Comment 2•19 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051027 Firefox/1.5 ID:2005102721
I see this (trunk): http://img386.imageshack.us/img386/8650/update0yu.png
After closing both instances and restarting one, it updates everything before opening, and it says, it is successful.
Comment 3•18 years ago
|
||
(In reply to comment #2)
> I see this (trunk): http://img386.imageshack.us/img386/8650/update0yu.png
> After closing both instances and restarting one, it updates everything before
> opening, and it says, it is successful.
Does the update start again and again? Then it is bug 340535.
(In reply to comment #1)
> The Windows installer has code to shut down other instances, which might be
> useful on that platform.
I add Robert who is working on the NSIS installer implementation.
Comment 6•17 years ago
|
||
This is true of both multiple profiles and the new -app switch to run xulapps on firefox. If we are going to be suggesting people use the -app switch to run their applications then we should be fixing this.
Flags: blocking-firefox3?
Updated•17 years ago
|
Version: 1.5.0.x Branch → Trunk
Comment 7•17 years ago
|
||
This is, hmm, annoyingly bad. Robert, will bug 340535 help here?
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P2
Target Milestone: --- → Firefox 3 M11
Assignee | ||
Comment 8•17 years ago
|
||
IMO yes... bug 340535 will make it so an OS reboot will be required if files are in use during software update.
Comment 9•17 years ago
|
||
But what prevents the user to autostart with the second profile and having the same problem again when starting his normal profile with the already downloaded update? I think it could happen more often for applications started with -app. We will run in an endless loop and aren't able to run the update. Except the user will be notified which process has opened the files.
Assignee | ||
Comment 10•17 years ago
|
||
The app exe is replaced with helper.exe and a notification telling the user that the IS must be restarted is displayed if they try to open the app along with the option to restart now.
Comment 11•17 years ago
|
||
Update of Target Milestone needed?
Comment 12•17 years ago
|
||
I remove TM since beta 3 is already released. Setting a new TM should be done by the assignee or drivers.
Target Milestone: Firefox 3 beta3 → ---
Updated•17 years ago
|
Assignee: nobody → robert.bugzilla
Comment 13•17 years ago
|
||
On discussion with Rob and Beltzner, we're going to minus this for Fx3, as we are not 100% confident that the solution won't break edge cases. This isn't a regression from Fx3, so we're at least not making things worse, and we're going to try to get to it after we ship so there's a lot of time to find edgecases.
Flags: blocking-firefox3+ → blocking-firefox3-
Updated•16 years ago
|
Product: Firefox → Toolkit
Assignee | ||
Comment 14•15 years ago
|
||
This is now fixed on trunk and 1.9.2 for Firefox 3.6 via bug 525390
You need to log in
before you can comment on or make changes to this bug.
Description
•