Closed Bug 314349 Opened 19 years ago Closed 19 years ago

Reply/Forward/Edit with .EML or message/rfc822: fails if no Message-Id

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED
Thunderbird2.0

People

(Reporter: mcow, Assigned: mscott)

References

(Blocks 1 open bug)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

TB 1.6a1-1028, Win2K With the patches for bug 268746 and bug 204350, it is now possible to use the Reply, Forward and Edit As New commands in a message window that's displaying a .EML file or a message/rfc822 attachment. However, if the message in question does not have a Message-ID header, the function fails; nothing happens, and the JavaScript console displays: === Error: messageID has no properties Source File: chrome://messenger/content/mailCommands.js Line: 222 === Steps to reproduce: 1) Save a message as a .EML file 2) Edit the file, remove the Message-ID header 3) Open the edited file (File | Open) 4) Try the Reply, Forward, Edit as New commands (from menu, context menu, toolbar) 5) Start a new message; attach the edited file; send to yourself on receipt, select the message and open the attachment 6) Try the Reply, Forward, Edit as New commands Actual results: No new compose window, error in JavaScript console Expected results: New compose window, initialized per the original message's contents/headers This is not a major issue since most messages have a Message-ID header, but sometimes while testing it's convenient to create a message from scratch, and it would be nice not to have to remember to add this header. Note that a message in the folders that lacks a Message-ID does not fail.
This may not be a core bug after all; I just tried to reproduce with a .EML file with Seamonkey 1.1a-1031, and didn't see the problem. Or maybe it was fixed in TB? I'll get a new trunk build of TB sometime this week and check.
(In reply to comment #1) > Or maybe it was fixed in TB? I'll get a new trunk build of TB sometime > this week and check. Still visible with TB 1.6a1-1101. Moving bug to Thunderbird.
Component: MailNews: Backend → Mail Window Front End
Product: Core → Thunderbird
Flags: blocking-aviary2?
Flags: blocking-firefox2? → blocking-thunderbird2?
This should be an easy bug to fix.
Flags: blocking-thunderbird2?
Target Milestone: --- → Thunderbird2.0
Attached patch the fix (deleted) — Splinter Review
Assignee: nobody → mscott
Status: NEW → ASSIGNED
this change isn't dependent on putting the .eml fixes onto the branch so I checked it in there.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
V with TB 1.6a1-0127. Checked forward and reply for both the .EML and message/rfc822 cases. However, I now see a new symptom: bug 324954.
Status: RESOLVED → VERIFIED
*** Bug 330953 has been marked as a duplicate of this bug. ***
Comment on attachment 209765 [details] [diff] [review] the fix 'approval1.8.0.3=?': (ThunderBird only) Trivial JS code fix, no risk. (Any reason not to (have) fix MOZILLA_1_8_0_BRANCH too ?)
Attachment #209765 - Flags: approval1.8.0.3?
Comment on attachment 209765 [details] [diff] [review] the fix we've had this conversation before. Please stop suggesting your warning patches for the security branches. Thanks.
Attachment #209765 - Flags: approval1.8.0.3? → approval1.8.0.3-
Comment on attachment 209765 [details] [diff] [review] the fix I incorrectly assumed this was a JS warning fix. Sorry Serge.
Attachment #209765 - Flags: approval1.8.0.3- → approval1.8.0.3?
Comment on attachment 209765 [details] [diff] [review] the fix Seems not to meet the criteria for a stability/security release, and has unfixed regressions to boot (324954). denying 1.8.0.3 request per drivers
Attachment #209765 - Flags: approval1.8.0.3? → approval1.8.0.3-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: