Closed Bug 314452 Opened 19 years ago Closed 19 years ago

Revoke events in ObjectURIChanged

Categories

(Core :: DOM: Core & HTML, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: Biesinger, Assigned: Biesinger)

References

Details

Attachments

(1 file)

nsObjectLoadingContent::ObjectURIChanged should revoke the events that are posted with it as owner. this is necessary so that previous async events don't interfere with potential sync instantiates done by this function.
Summary: Revoke plugins in ObjectURIChanged → Revoke events in ObjectURIChanged
OS: Linux → All
Priority: -- → P2
Hardware: PC → All
Target Milestone: --- → mozilla1.9alpha
OK, found a way to do this that avoids calling RevokeEvents in the common case (I fear that it's expensive, what with entering the monitor and iterating over all events in the queue) We only need to revoke any events if our current type is eType_Plugin: Only in those cases can we have a posted event. Fallback/UnloadContent does not need to call it. either we have no frame, or we kill the frame. so the frame comparison in HandleEvent would fail. I wonder if HandleEvent should compare mURI/mContentType against the current uri/type, though...
Attached patch patch (deleted) — Splinter Review
Attachment #201508 - Flags: superreview?(bzbarsky)
Attachment #201508 - Flags: review?(bzbarsky)
Status: NEW → ASSIGNED
Attachment #201508 - Flags: superreview?(bzbarsky)
Attachment #201508 - Flags: superreview+
Attachment #201508 - Flags: review?(bzbarsky)
Attachment #201508 - Flags: review+
Checking in content/base/src/nsObjectLoadingContent.cpp; /cvsroot/mozilla/content/base/src/nsObjectLoadingContent.cpp,v <-- nsObjectLoadingContent.cpp new revision: 1.12; previous revision: 1.11 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: