User-Agent: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20051031 Firefox/1.6a1 Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20051031 Firefox/1.6a1 fix of bug 313326 broke BeOS build during linking. Verified under both Zeta 1.1 and BeOS R5.0.3. Fix is link to -lgame in mozilla/browser/app/Makefile.in. See patch. Reproducible: Always Steps to Reproduce: 1. start with a clean tree 2. make firefox 3. wait until breakage Actual Results: build breaks. Expected Results: build should complete.

Comment on attachment 201424 [details] [diff] [review] one-line fix to Makefile.in r=thesuckiestemail@yahoo.se What more is needed to get this commited?

As this is outside BeOS-only folder, probably it needs formal superreview? Also someone to commit. Actually i'm wondering which item there uses both nsSound and BFilePanel, i thought that already linked libwidget_beos.so is enough...

Also I suspect that only STATIC builds are broken. Is it right?

fyysik, you've correctly guessed I have tested only with static builds. I will back the patch out of my tree and try a debug build under R5.0.3, then let you know.

what about seamonkey static builds?

confirming fyysik's guess: problem only occurs with static builds. Built a debug version under R5.0.3 without issue.

Updating title to reflect that.

maybe XULRunner and Sunbird also require -lgame explicitly

They might.

confirming: SeaMonkey static builds are also broken. Fix in 1st patch doesn't seem to apply to SeaMonkey, though, as the "/browser/apps" subdirectory doesn't exist. The exact same line (with -ltracker) also exists in /mozilla/embedding/componentlib/Makefile.in, but adding "-lgame" doesn't fix problem. Hopefully the attached terminal output will help diagnose the issue; it looks like more may be wrong in SeaMonkey than Firefox.

try xpfe/bootstrap

it seems we need changes in in xpfe/bootstrap/Makefile.in directly or somewhere like config/rules-static.mk (don't remember atm) to add both -ltracker and -lgame to extra dso libs

I think we can fix this problem step by step with separate patches - first for FF, then for SeaMonkey and then, if needed, for other Gecko-based apps like Thunderbird, Sundbird and whatelse. Your opinion, biesi?

sure, that's fine.

While we're on the subject, should we try to ifdef these for static builds only?

I think we only need to link when doing static builds.

Comment on attachment 201926 [details] [diff] [review] Only link tracker, game when static for Firefox r=sergei_d looks like sample solution also for Seamonkey

I patched pretty much all places, but I've only built Firefox yet, so not sure it will work for other places.

Comment on attachment 201926 [details] [diff] [review] Only link tracker, game when static for Firefox asking for second review (it seems in this component sr means also that:). Simple platform-specific patch

patch commited by timeless 1.90 <- 1.89

review request. adding libtracker and libgame for SeaMonkey static builds in same way as it done for Firefeox

Just curious, shouldn't tracker have been there before? Is that done in some other place for Seamonkey as well? Maybe here? http://lxr.mozilla.org/seamonkey/source/browser/app/Makefile.in#157

Oops, mixed up /browser with xpfe..

Comment on attachment 203725 [details] [diff] [review] patch sr request.

Comment on attachment 203725 [details] [diff] [review] patch I'm not a superreviewer, but it doesn't really matter since this is a build-config patch anyway.

checked in SeaMonkey trunk by timeless: 2005-11-22 14:3 Version 1.285 closing bug

Bug 313326 requires this fix to create good static builds. So it needs to be applied to the branch as well.

Patch that applies cleanly to the MOZILLA_1_8_BRANCH. Doug, could you test this before I request approval?

Comment on attachment 230880 [details] [diff] [review] Patch for 1_8 branch (for mozilla/browser/app) Requesting approval for landing in the MOZILLA_1_8_BRANCH. Testing on the trunk pointed out that this patch did not affect any other platforms.

Comment on attachment 230880 [details] [diff] [review] Patch for 1_8 branch (for mozilla/browser/app) a=drivers

Comment on attachment 203725 [details] [diff] [review] patch Requesting approval for landing in the MOZILLA_1_8_BRANCH of xpfe. Affects only BeOS-section in Makefile.in

Checking in mozilla/browser/app/Makefile.in; /cvsroot/mozilla/browser/app/Makefile.in,v <-- Makefile.in new revision: 1.85.2.8; previous revision: 1.85.2.7 done waiting for xpfe-equivalent approval to add Fixed 1.8.1 keyword

Comment on attachment 203725 [details] [diff] [review] patch a=schrep for drivers for BeOS only change.

Checking in mozilla/xpfe/bootstrap/Makefile.in; /cvsroot/mozilla/xpfe/bootstrap/Makefile.in,v <-- Makefile.in new revision: 1.283.2.2; previous revision: 1.283.2.1 done Now fixed for 1.8.1 branch