Closed Bug 314663 Opened 19 years ago Closed 19 years ago

#urlbar style rules don't belong in toolkit's autocomplete.css

Categories

(Firefox :: General, defect, P2)

Product:
Firefox
Component:
General
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 2 alpha1

People

(Reporter: Gavin, Assigned: Gavin)

References

(
URL
)

Details

(Keywords: verified1.8.1)

Attachments

(1 file, 1 obsolete file)

updated patch
(deleted), patch
mconnor
: review+
mconnor
: approval-branch-1.8.1+
Details | Diff | Splinter Review
Bug 263750 added browser-specific style rules to toolkit's autocomplete.css, because those rules are only wanted when using gnomestripe. This can be fixed by ifdef'ing winstripe's browser.css and adding the rules there.
Status: NEW → ASSIGNED
Attached patch patch (obsolete) (deleted) — — Splinter Review
I'll get someone to test this before asking for review.
Priority: -- → P2
Target Milestone: --- → Firefox1.6-
At Gavin's request, I applied the patch to my firefox CVS build (Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051103 Firefox/1.6a1). With the patch in place, I'm not seeing any change in the URL bar's behavior. In particular the background still turns yellow when displaying an https page and back to white for non-https.
Attachment #201586 - Flags: review?(mconnor)
Whiteboard: [patch-r?]
Attachment #201586 - Flags: review?(mconnor) → review?(bugs.mano)
Comment on attachment 201586 [details] [diff] [review] patch Gnomestipe is only used on GTK2, if bug 263750 applies to GTK1 builds too, let's define XP_GNOME only if either MOZ_WIDGET_GTK or MOZ_WIDGET_GTK2 are defined.
Attachment #201586 - Flags: review?(bugs.mano)
I'm not sure I understand. Your concern is that this code was not previously used for GTK1, but with my patch will be? http://lxr.mozilla.org/seamonkey/source/toolkit/themes/Makefile.in#60
If that is what you mean, I'm not sure how I'm supposed to test whether bug 263750 is still present in GTK1 builds... how supported is GTK1? I can't find any builds on the ftp server (balsa doesn't seem to upload any).
Ask Mike, I'm not sure if we still even try to support GTK1 (theme-wise). If we don't, just #ifdef MOZ_WIDGET_GTK2 it.
Attached patch updated patch (deleted) — — Splinter Review
Mike said we don't care about GTK1, and this shouldn't break anything that's not already broken.
Attachment #201586 - Attachment is obsolete: true
Comment on attachment 206975 [details] [diff] [review] updated patch Adam tested, it works.
Attachment #206975 - Flags: review?(mconnor)
Attachment #206975 - Flags: review?(mconnor) → review+
mozilla/browser/themes/winstripe/browser/browser.css; new revision: 1.23; mozilla/browser/themes/winstripe/browser/jar.mn; new revision: 1.15; mozilla/toolkit/themes/gnomestripe/global/autocomplete.css; new revision: 1.9;
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [patch-r?]
Attachment #206975 - Flags: branch-1.8.1?(mconnor)
Attachment #206975 - Flags: branch-1.8.1?(mconnor) → branch-1.8.1+
Checked in on the 1.8 branch. mozilla/browser/themes/winstripe/browser/browser.css; new revision: 1.17.2.9; mozilla/browser/themes/winstripe/browser/jar.mn; new revision: 1.13.2.2; mozilla/toolkit/themes/gnomestripe/global/autocomplete.css; new revision: 1.8.4.1;
Keywords: fixed1.8.1
Target Milestone: Firefox 2 → Firefox 2 alpha1
Verified FIXED by code inspection.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1 → verified1.8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: