Closed Bug 316267 Opened 19 years ago Closed 19 years ago

[FIX]ASSERTION: Placeholder relationship should have been torn down

Categories

(Core :: Layout, defect, P2)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha1

People

(Reporter: martijn.martijn, Assigned: bzbarsky)

References

Details

(Keywords: assertion, testcase)

Attachments

(3 files)

testcase
(deleted), text/html
Details
Patch
(deleted), patch
dbaron
: review+
dbaron
: superreview+
Details | Diff | Splinter Review
Document rules, add some more sanity assertions
(deleted), patch
roc
: review+
roc
: superreview+
Details | Diff | Splinter Review
See upcoming testcase, when hovering over the document, You get this assertion in a debug build: ###!!! ASSERTION: Placeholder relationship should have been torn down: '!shell-> FrameManager()->GetPlaceholderFrameFor(mOutOfFlowFrame)', file c:/mozilla/mozill a/layout/generic/nsPlaceholderFrame.cpp, line 87
Summary: SSERTION: Placeholder relationship should have been torn down → ASSERTION: Placeholder relationship should have been torn down
Attached file testcase (deleted) —
Blocks: cssgen
Blocks: 334132
*** Bug 334132 has been marked as a duplicate of this bug. ***
Attached patch Patch (deleted) — — Splinter Review
I'm pretty sure this is fine as it is (because we kill the entire placeholder map right after this method), but I do think we should avoid the assert, like so.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #218613 - Flags: superreview?(dbaron)
Attachment #218613 - Flags: review?(dbaron)
Note: I don't think we need this on the branches or anything, but correct me if I'm wrong?
OS: Windows XP → All
Priority: -- → P2
Hardware: PC → All
Summary: ASSERTION: Placeholder relationship should have been torn down → [FIX]ASSERTION: Placeholder relationship should have been torn down
Target Milestone: --- → mozilla1.9alpha
Comment on attachment 218613 [details] [diff] [review] Patch I don't remember the logic of this at all, so I couldn't say one way or another what problems this could cause. Perhaps Mats can. Are the rules for this stuff documented anywhere?
Attachment #218613 - Flags: superreview?(dbaron)
Attachment #218613 - Flags: superreview+
Attachment #218613 - Flags: review?(dbaron)
Attachment #218613 - Flags: review+
Attachment #218634 - Flags: superreview?(dbaron)
Attachment #218634 - Flags: review?(dbaron)
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Attachment #218634 - Flags: superreview?(roc)
Attachment #218634 - Flags: superreview?(dbaron)
Attachment #218634 - Flags: review?(roc)
Attachment #218634 - Flags: review?(dbaron)
Attachment #218634 - Flags: superreview?(roc)
Attachment #218634 - Flags: superreview+
Attachment #218634 - Flags: review?(roc)
Attachment #218634 - Flags: review+
Checked in the assertions too.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: