In trademarks reviews for 1.5, we permitted locales to have less or more ordered search plugins than the two we have in en-US, compare-locales should support that. http://lxr.mozilla.org/mozilla1.8/source/browser/locales/en-US/chrome/browser-region/region.properties#13 is the reference. I'll attach a patch in a minute, and I'd like us to take that into the build for 1.5 so that we can see what is actually green and what is not. I tested my modified version on the hy-AM and ja locales, hy-AM has the same errors, ja just doesn't have the browser.search.order ones anymore. I made up my mind to not require a single ordered one, but this is just an arbitrary decision for now, every locale has at least one.

This follows pretty strictly what we did in http://lxr.mozilla.org/aviary101branch/source/toolkit/locales/compare-locales.pl#125 to ignore the added XSLT entry.

Comment on attachment 203234 [details] [diff] [review] ignore /browser\.search\.order\.[1-9]/ in region.properties Requesting approval, we really want to see which locales are green and which are not.

a=me for the 1.8 branch as this should only effect Tinderbox and not the actual binaries we are producing. I would plus the patch but we've already killed the approval flag for 1.8rc2 changes.

(In reply to comment #3) > a=me for the 1.8 branch as this should only effect Tinderbox and not the actual > binaries we are producing. > > I would plus the patch but we've already killed the approval flag for 1.8rc2 > changes. Ah, that's why I couldn't plus earlier. :) a=chase, too, for a build config fix. Axel, feel free to land this.

Comment on attachment 203234 [details] [diff] [review] ignore /browser\.search\.order\.[1-9]/ in region.properties checked in on the branch, I'll cover the trunk later today, when things are less hectic

tested and reviewed and broken. Silly me. Fixing for real this time around. Only add iff it's not in the other one and it's not region.properties AND it's not browser.search.order.

/me pings chase

Comment on attachment 204796 [details] [diff] [review] logic is hard, let's go shopping. Just setting the approval flags to be on the right side, this is just a l10n-tinderbox only change, that we want on all branches.

Comment on attachment 204796 [details] [diff] [review] logic is hard, let's go shopping. a=dveditz for drivers

Fixed on the branches, patch for the trunk coming up.

checked in on the trunk, too.