Closed
Bug 316674
Opened 19 years ago
Closed 19 years ago
compare-locales should support reasonable numbers of ordered search
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Pike, Assigned: Pike)
Details
(Keywords: fixed1.8.0.1, fixed1.8.1)
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
chase
:
review+
dveditz
:
approval1.8.0.1+
dveditz
:
approval1.8.1+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
In trademarks reviews for 1.5, we permitted locales to have less or more
ordered search plugins than the two we have in en-US, compare-locales
should support that.
http://lxr.mozilla.org/mozilla1.8/source/browser/locales/en-US/chrome/browser-region/region.properties#13
is the reference.
I'll attach a patch in a minute, and I'd like us to take that into the build
for 1.5 so that we can see what is actually green and what is not.
I tested my modified version on the hy-AM and ja locales, hy-AM has the same
errors, ja just doesn't have the browser.search.order ones anymore.
I made up my mind to not require a single ordered one, but this is just an
arbitrary decision for now, every locale has at least one.
Assignee | ||
Comment 1•19 years ago
|
||
This follows pretty strictly what we did in
http://lxr.mozilla.org/aviary101branch/source/toolkit/locales/compare-locales.pl#125
to ignore the added XSLT entry.
Attachment #203234 -
Flags: superreview?(benjamin)
Attachment #203234 -
Flags: review?
Assignee | ||
Updated•19 years ago
|
Attachment #203234 -
Flags: review? → review?(gandalf)
Updated•19 years ago
|
Attachment #203234 -
Flags: review?(gandalf) → review+
Updated•19 years ago
|
Attachment #203234 -
Flags: superreview?(benjamin) → superreview+
Assignee | ||
Comment 2•19 years ago
|
||
Comment on attachment 203234 [details] [diff] [review]
ignore /browser\.search\.order\.[1-9]/ in region.properties
Requesting approval, we really want to see which locales are green and which are not.
Attachment #203234 -
Flags: approval1.8rc2?
Comment 3•19 years ago
|
||
a=me for the 1.8 branch as this should only effect Tinderbox and not the actual binaries we are producing.
I would plus the patch but we've already killed the approval flag for 1.8rc2 changes.
Comment 4•19 years ago
|
||
(In reply to comment #3)
> a=me for the 1.8 branch as this should only effect Tinderbox and not the actual
> binaries we are producing.
>
> I would plus the patch but we've already killed the approval flag for 1.8rc2
> changes.
Ah, that's why I couldn't plus earlier. :) a=chase, too, for a build config fix.
Axel, feel free to land this.
Assignee | ||
Comment 5•19 years ago
|
||
Comment on attachment 203234 [details] [diff] [review]
ignore /browser\.search\.order\.[1-9]/ in region.properties
checked in on the branch, I'll cover the trunk later today, when things are less hectic
Attachment #203234 -
Flags: approval1.8rc2?
Assignee | ||
Comment 6•19 years ago
|
||
tested and reviewed and broken. Silly me. Fixing for real this time around.
Only add iff it's not in the other one and it's not region.properties AND it's
not browser.search.order.
Attachment #203234 -
Attachment is obsolete: true
Attachment #204796 -
Flags: review?(chase)
Assignee | ||
Comment 7•19 years ago
|
||
/me pings chase
Updated•19 years ago
|
Attachment #204796 -
Flags: review?(chase) → review+
Assignee | ||
Comment 8•19 years ago
|
||
Comment on attachment 204796 [details] [diff] [review]
logic is hard, let's go shopping.
Just setting the approval flags to be on the right side, this is just a l10n-tinderbox only change, that we want on all branches.
Attachment #204796 -
Flags: approval1.8.1?
Attachment #204796 -
Flags: approval1.8.0.1?
Comment 9•19 years ago
|
||
Comment on attachment 204796 [details] [diff] [review]
logic is hard, let's go shopping.
a=dveditz for drivers
Attachment #204796 -
Flags: approval1.8.1?
Attachment #204796 -
Flags: approval1.8.1+
Attachment #204796 -
Flags: approval1.8.0.1?
Attachment #204796 -
Flags: approval1.8.0.1+
Assignee | ||
Comment 10•19 years ago
|
||
Fixed on the branches, patch for the trunk coming up.
Keywords: fixed1.8.0.1,
fixed1.8.1
Assignee | ||
Comment 11•19 years ago
|
||
Attachment #208193 -
Flags: review?(benjamin)
Updated•19 years ago
|
Attachment #208193 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 12•19 years ago
|
||
checked in on the trunk, too.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•