the getter doesn't always return true/false, often it returns undefined this understandably makes domi fairly upset. Error ``aValue has no properties'' [xs] in file ``chrome://inspector/content/viewers/jsObject/jsObject.js'', line 213, character 0. Stopped for error handler. #0: function anonymous(aTreeChildren=XULElement:{0}, aName=string:"readonly", aValue=void:void, aObject=XULElement:{45}) in <chrome://inspector/content/viewers/jsObject/jsObject.js> line 213 211: } else { 212: try { 213: value = aValue.toString(); 214: value = value.replace(/\n|\r|\t|\v/g, " "); 215: } catch (ex) { 0001: aValue $[0] = [void] void 0001: aObject.readonly $[1] = [void] void 0001: aObject.inputField.readonly $[2] = [void] void 0001: aObject.inputField.getAttribute('readonly') $[3] = [null] null 0001: aObject.readonly $[4] = [void] void 0001: aObject.readonly=true $[5] = [boolean] true 0001: aObject.readonly $[6] = [boolean] true 0001: aObject.readonly=false $[7] = [boolean] false 0001: aObject.readonly $[8] = [boolean] false 0001: aObject.inputField.getAttribute('readonly') $[9] = [null] null 0001: aObject.inputField.readonly $[10] = [boolean] false 0001: delete aObject.inputField.readonly $[11] = [boolean] true 0001: aObject.inputField.readonly $[12] = [void] void 0001: aObject.inputField $[13] = [HTMLInputElement] [class: HTMLInputElement] {1}

Comment on attachment 204533 [details] [diff] [review] simplify code Prevailing style seems somewhat inconsistent, but definitely does not use getAttribute for properties available (when spelled correctly) on the input.

Comment on attachment 215613 [details] [diff] [review] Use right case for readOnly property This has been on the trunk for nearly 4 months - it's a simple correctness fix that should land on the 1.8 branch. It blocks bug 343687.

mozilla/xpfe/global/resources/content/bindings/textbox.xml 1.32.4.5 mozilla/toolkit/content/widgets/textbox.xml 1.21.4.10

Wasn't this the kind of API change that should not go on a frozen-API-stable branch such as 1.8? /be

Unclear... We made no promises about the XUL "api", somehow -- that's why we're revving the extension minVersion.