Closed Bug 320854 Opened 19 years ago Closed 19 years ago

o.hasOwnProperty('length') lies when o has function in proto chain

Categories

(Core :: JavaScript Engine, defect, P3)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9alpha1

People

(Reporter: bc, Assigned: brendan)

References

(
URL
)

Details

(Keywords: verified1.8.0.1, verified1.8.1)

Attachments

(1 file)

proposed fix
(deleted), patch
shaver
: review+
shaver
: superreview+
dveditz
: approval1.8.0.1+
dveditz
: approval1.8.1+
Details | Diff | Splinter Review
Spun off of bug 313570.
Assignee: general → brendan
OS: Windows XP → All
Priority: -- → P3
Hardware: PC → All
Target Milestone: --- → mozilla1.9alpha
I moved the length test from bug 313570 to bug 320854. Checking in ecma_3/Object/regress-320854.js; /cvsroot/mozilla/js/tests/ecma_3/Object/regress-320854.js,v <-- regress-320854.js initial revision: 1.1 done Checking in ecma_3/Function/regress-313570.js; /cvsroot/mozilla/js/tests/ecma_3/Function/regress-313570.js,v <-- regress-313570.js new revision: 1.2; previous revision: 1.1 done
Flags: testcase+
Attached patch proposed fix (deleted) — — Splinter Review
Attachment #206321 - Flags: superreview?(shaver)
Attachment #206321 - Flags: review?(mrbkap)
Comment on attachment 206321 [details] [diff] [review] proposed fix r=mrbkap
Attachment #206321 - Flags: review?(mrbkap) → review+
Comment on attachment 206321 [details] [diff] [review] proposed fix sr=shaver.
Attachment #206321 - Flags: superreview?(shaver)
Attachment #206321 - Flags: superreview+
Attachment #206321 - Flags: review?(mrbkap)
Attachment #206321 - Flags: review+
Comment on attachment 206321 [details] [diff] [review] proposed fix you know what'd be neat? mid-air protection for flags
Attachment #206321 - Flags: review?(mrbkap) → review+
Fixed. Not important enough for 1.8.0.x, but should get into 1.8.1. But so should almost every such fix, so I'm not sure I want to keep nominating. For now I will, however, to make it easy to query. /be
Status: NEW → RESOLVED
Closed: 19 years ago
Flags: blocking1.8.1?
Resolution: --- → FIXED
verified windows/linux/mac
Status: RESOLVED → VERIFIED
Attachment #206321 - Flags: approval1.8.1?
Attachment #206321 - Flags: approval1.8.0.1?
Comment on attachment 206321 [details] [diff] [review] proposed fix Since the fix for bug 320119 was approved, this patch could be too. It makes a related case to-do with the built-in length property of function objects work. It's a one-line change not counting the comment. /be
Comment on attachment 206321 [details] [diff] [review] proposed fix a=dveditz
Attachment #206321 - Flags: approval1.8.1?
Attachment #206321 - Flags: approval1.8.1+
Attachment #206321 - Flags: approval1.8.0.1?
Attachment #206321 - Flags: approval1.8.0.1+
fixed on both branches according to bonsai: 2006-01-10 20:56 brendan%mozilla.org mozilla/ js/ src/ jsobj.c 3.208.2.15 MOZILLA_1_8_BRANCH 16/1 Fix for 320854, a=dveditz. 2006-01-10 20:58 brendan%mozilla.org mozilla/ js/ src/ jsobj.c 3.208.2.12.2.3 MOZILLA_1_8_0_BRANCH 16/1 Fix for 320854, a=dveditz.
Keywords: fixed1.8.0.1, fixed1.8.1
verified fixed 2005-01-11 builds on 1.8.0.1, 1.8.1, trunk windows/linux/mac
Keywords: fixed1.8.0.1, fixed1.8.1 → verified1.8.0.1, verified1.8.1
no need to block 1.8.1 it is already fixed yonder.
Flags: blocking1.8.1?
Blocks: js1.6rc1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: