User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8) Gecko/20051111 Firefox/1.5 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8) Gecko/20051111 Firefox/1.5 I have spotted that on certain pages, e.g. Select Product (editproducts.cgi) the table rows are coloured using in-line attributes (e.g. <tr bgcolor="#6666FF">). This looks god-awful in my personalised template, which is fairly purple, and cannot be changed using CSS, as the local setting always overrides. This, and any other inline attributes that affect appearance in this way, should be moved to the appropriate stylesheet. More specifically, all non-semantic mark-up should be moved to linked CSS files. Reproducible: Always

This has been fixed in 2.21 with the editproducts templating, hasn't it?

(In reply to comment #1) > This has been fixed in 2.21 with the editproducts templating, hasn't it? > No it hasn't. 38: <tr bgcolor="#6666ff"> 48: <tr bgcolor="#bbbbbb"> ./admin/products/groupcontrol/edit.html.tmpl 44: <tr bgcolor="#6666FF"> 238: <table border="0" cellpadding="20" width="70%" bgcolor="red"> ./admin/products/confirm-delete.htm And many other templates use bgcolor too. This bug is valid and, I agree, should be fixed. But this won't be done before 2.24. Mark Clements, if you want to post a patch, feel free. ;) Else I suspect this bug won't be a top priority.

If we're serious about skinability, then it should settle in somewhere higher than in the range that "not top priority" suggests ;)

I can fix the code, but I don't have a clue how I then go about submitting a patch from my modified version. If someone could point me in the right direction I might be able to look into it. (Although having said that, a more co-ordinated approach to skinning might be useful - is anyone in charge of this issue at the moment?).

Mark (if you still read this after >6 months): To submit a patch use "cvs diff -u > file" against the Bugzilla root dir after you have made your change (at least, that is what I do). As for coordination, it appears not (skinning is worked through the same avenues as general UI issues)

reassigning this bug to me and it will be marked of a duplicate once i have filed the bug with the patch that removes the most ids from a template.

This patch removes bgcolor. I will attach a separate bug to remove color and other style attributes as this patch is already big enough.

I included the removal of the 'color' attribute in this patch. There are 2 occurences of 'color' in quips which will be removed in bug 918013, so I left them alone here. I also converted <tt> to <kbd> in create_guided.html.tmpl as <tt> is deprecated in HTML5. <font> is deprecated too, which is why I replaced it by <span>.

I fixed the message for series_updated to match series_created and series_deleted.

err... wrong patch. Sorry for bugspam.

Comment on attachment 8350942 [details] [diff] [review] patch, v1.2 >Index: template/en/default/admin/products/edit.html.tmpl >- [% IF component.description %] >- [% component.description FILTER html_light %] >- [% ELSE %] >- <font color="red">description missing</font> >- [% END %] >+ [% component.description FILTER html_light %] Was removing the ELSE part of this intentional? Everything else in here looks good to me. The + holds if the above really was intentional, otherwise you might want to fix that. :)

(In reply to Dave Miller [:justdave] (justdave@bugzilla.org) from comment #11) > Was removing the ELSE part of this intentional? Yes, it's intentional. A component description cannot be empty, so we never reach the ELSE part of the code. Thanks for the review! :)

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/ modified chart.cgi modified skins/standard/admin.css modified skins/standard/enter_bug.css modified skins/standard/global.css modified skins/standard/show_bug.css modified template/en/default/filterexceptions.pl modified template/en/default/account/profile-activity.html.tmpl modified template/en/default/admin/table.html.tmpl modified template/en/default/admin/classifications/del.html.tmpl modified template/en/default/admin/classifications/edit.html.tmpl modified template/en/default/admin/classifications/reclassify.html.tmpl modified template/en/default/admin/classifications/select.html.tmpl modified template/en/default/admin/components/confirm-delete.html.tmpl modified template/en/default/admin/components/list.html.tmpl modified template/en/default/admin/components/select-product.html.tmpl modified template/en/default/admin/custom_fields/confirm-delete.html.tmpl modified template/en/default/admin/custom_fields/list.html.tmpl modified template/en/default/admin/fieldvalues/confirm-delete.html.tmpl modified template/en/default/admin/fieldvalues/list.html.tmpl modified template/en/default/admin/fieldvalues/select-field.html.tmpl modified template/en/default/admin/flag-type/list.html.tmpl modified template/en/default/admin/groups/list.html.tmpl modified template/en/default/admin/keywords/list.html.tmpl modified template/en/default/admin/milestones/confirm-delete.html.tmpl modified template/en/default/admin/milestones/list.html.tmpl modified template/en/default/admin/milestones/select-product.html.tmpl modified template/en/default/admin/params/common.html.tmpl modified template/en/default/admin/products/confirm-delete.html.tmpl modified template/en/default/admin/products/edit.html.tmpl modified template/en/default/admin/products/list-classifications.html.tmpl modified template/en/default/admin/products/list.html.tmpl modified template/en/default/admin/products/groupcontrol/edit.html.tmpl modified template/en/default/admin/users/list.html.tmpl modified template/en/default/admin/versions/confirm-delete.html.tmpl modified template/en/default/admin/versions/list.html.tmpl modified template/en/default/admin/versions/select-product.html.tmpl modified template/en/default/attachment/confirm-delete.html.tmpl modified template/en/default/attachment/show-multiple.html.tmpl modified template/en/default/bug/dependency-tree.html.tmpl modified template/en/default/bug/navigate.html.tmpl modified template/en/default/bug/create/create-guided.html.tmpl modified template/en/default/bug/create/create.html.tmpl modified template/en/default/global/confirm-user-match.html.tmpl modified template/en/default/global/messages.html.tmpl modified template/en/default/reports/edit-series.html.tmpl modified template/en/default/reports/keywords.html.tmpl modified template/en/default/whine/mail.html.tmpl Committed revision 8837.