Need to port/make use of TB's improved integration with OSX for mailnews

This patch: * Adds relevant bits from TB's nsMailModule.cpp into nsMsgFactory.cpp * Alters Makefile.in in mailnews/base/src to compile nsMessengerOSXIntegration.cpp Not saying this will work as I do not, currently, have an OSX build environment - so can someone test and feed back?

Tried compiling with this patch and get an error which suggests it needs -lobjc when compiling the library it goes in. Any ideas how to add that to the build process?

(In reply to comment #2) > Tried compiling with this patch and get an error which suggests it needs -lobjc > when compiling the library it goes in. Any ideas how to add that to the build > process? > Hmm, I suppose you mean this: ld: nsMessengerOSXIntegration.o illegal reference to symbol: _ATSUCreateStyle defined in indirectly referenced dynamic library /Developer/SDKs/MacOSX10.2.8.sdk/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD ld: nsMessengerOSXIntegration.o illegal reference to symbol: _BeginCGContextForApplicationDockTile defined in indirectly referenced dynamic library /Developer/SDKs/MacOSX10.2.8.sdk/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox ld: nsMessengerOSXIntegration.o illegal reference to symbol: _CGContextAddArc defined in indirectly referenced dynamic library /Developer/SDKs/MacOSX10.2.8.sdk/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics ld: nsMessengerOSXIntegration.o illegal reference to symbol: _GetScriptManagerVariable defined in indirectly referenced dynamic library /Developer/SDKs/MacOSX10.2.8.sdk/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore make[6]: *** [libmailnews.dylib] Error 1 make[5]: *** [libs] Error 2 make[4]: *** [libs] Error 2 make[3]: *** [libs_tier_99] Error 2 make[2]: *** [tier_99] Error 2 make[1]: *** [alldep] Error 2 make: *** [alldep] Error 2

<bsmedberg> stefanh: looks like you need -framework ApplicationServices This is definately not my area... cc:ing mento who might be able to help.

(In reply to comment #3) > (In reply to comment #2) > > Tried compiling with this patch and get an error which suggests it needs -lobjc > > when compiling the library it goes in. Any ideas how to add that to the build > > process? > > > > Hmm, I suppose you mean this: > > ld: nsMessengerOSXIntegration.o illegal reference to symbol: _ATSUCreateStyle > defined in indirectly referenced dynamic library yes, something like that :-S

When it comes to building on mac - in what way does seamonkey differ from thunderbird?

I don't have a C-Monkey build around right now to check, but try adding something like this: ifneq (,$(filter cocoa mac, $(MOZ_WIDGET_TOOLKIT))) LIBS += -framework ApplicationServices endif to mailnews/base/build/Makefile.in .

Added that change to the end of the Makefile.in in mailnews/base/build and get the following, slightly different, errors: g++ -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -fpascal-strings -no-cpp-precomp -fno-common -fshort-wchar -I/Developer/Headers/FlatCarbon -pipe -DNDEBUG -DTRIMMED -O2 -fPIC -arch ppc -o libmailnews.dylib nsMsgFactory.o nsMessenger.o nsMessengerBootstrap.o nsUrlListenerManager.o nsMsgMailSession.o nsMsgAccountManager.o nsMsgAccount.o nsCopyMessageStreamListener.o nsMsgRDFDataSource.o nsMsgFolderDataSource.o nsMsgAccountManagerDS.o nsMsgRDFUtils.o nsMsgBiffManager.o nsMsgPurgeService.o nsMsgCopyService.o nsMsgFolderCache.o nsMsgFolderCacheElement.o nsMsgFolderCompactor.o nsMsgStatusFeedback.o nsMsgWindow.o nsMessengerMigrator.o nsMsgServiceProvider.o nsSubscribeDataSource.o nsSubscribableServer.o nsMsgPrintEngine.o nsStatusBarBiffManager.o nsMsgDBView.o nsMsgThreadedDBView.o nsMsgSpecialViews.o nsMsgQuickSearchDBView.o nsMsgSearchDBView.o nsMsgXFVirtualFolderDBView.o nsMsgGroupThread.o nsMsgGroupView.o nsMsgOfflineManager.o nsMsgProgress.o nsMessengerContentHandler.o nsSpamSettings.o nsCidProtocolHandler.o nsMessengerOSXIntegration.o nsMsgFilterService.o nsMsgFilterList.o nsMsgFilter.o nsMsgSearchTerm.o nsMsgBodyHandler.o nsMsgLocalSearch.o nsMsgSearchValue.o nsMsgSearchAdapter.o nsMsgSearchSession.o nsMsgImapSearch.o nsMsgSearchNews.o nsMsgFilterDataSource.o nsMsgFilterDelegateFactory.o -Wl,-dead_strip -L../../../dist/bin -L../../../dist/lib -lmsgbaseutil -lrdfutil_s -L../../../dist/bin -lmozjs ../../../dist/lib/libunicharutil_s.a -L../../../dist/bin -lxpcom -lxpcom_core -L../../../dist/bin -L../../../dist/lib -lplds4 -lplc4 -lnspr4 -L../../../dist/lib -lxpcom_compat -Wl,-exported_symbols_list -Wl,/Users/ianneal/mozdev/mozilla/build/unix/gnu-ld-scripts/components-export-list -bundle ld: nsMessengerOSXIntegration.o illegal reference to symbol: _ATSUCreateStyle defined in indirectly referenced dynamic library /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD ld: nsMessengerOSXIntegration.o illegal reference to symbol: _BeginCGContextForApplicationDockTile defined in indirectly referenced dynamic library /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox ld: nsMessengerOSXIntegration.o illegal reference to symbol: _CGContextAddArc defined in indirectly referenced dynamic library /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics ld: nsMessengerOSXIntegration.o illegal reference to symbol: _GetScriptManagerVariable defined in indirectly referenced dynamic library /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore make[6]: *** [libmailnews.dylib] Error 1

Try OS_LIBS instead of LIBS.

New error now: ld: nsMessengerOSXIntegration.o illegal reference to symbol: _BeginCGContextForApplicationDockTile defined in indirectly referenced dynamic library /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox ld: warning multiple definitions of symbol _PL_ArenaAllocate ../../../dist/bin/libplds4.dylib(plarena.o) definition of _PL_ArenaAllocate /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(plarena.o) definition of _PL_ArenaAllocate ld: warning multiple definitions of symbol _PL_InitArenaPool ../../../dist/bin/libplds4.dylib(plarena.o) definition of _PL_InitArenaPool /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(plarena.o) definition of _PL_InitArenaPool ld: warning multiple definitions of symbol _PL_FreeArenaPool ../../../dist/bin/libplds4.dylib(plarena.o) definition of _PL_FreeArenaPool /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(plarena.o) definition of _PL_FreeArenaPool ld: warning multiple definitions of symbol _PL_FinishArenaPool ../../../dist/bin/libplds4.dylib(plarena.o) definition of _PL_FinishArenaPool /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(plarena.o) definition of _PL_FinishArenaPool ld: warning multiple definitions of symbol _PL_ArenaRelease ../../../dist/bin/libplds4.dylib(plarena.o) definition of _PL_ArenaRelease /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(plarena.o) definition of _PL_ArenaRelease ld: warning multiple definitions of symbol _PL_ArenaGrow ../../../dist/bin/libplds4.dylib(plarena.o) definition of _PL_ArenaGrow /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(plarena.o) definition of _PL_ArenaGrow ld: warning multiple definitions of symbol _PL_ArenaFinish ../../../dist/bin/libplds4.dylib(plarena.o) definition of _PL_ArenaFinish /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(plarena.o) definition of _PL_ArenaFinish ld: warning multiple definitions of symbol _PL_CompactArenaPool ../../../dist/bin/libplds4.dylib(plarena.o) definition of _PL_CompactArenaPool /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(plarena.o) definition of _PL_CompactArenaPool ld: warning multiple definitions of symbol _PR_GetError ../../../dist/bin/libnspr4.dylib(prerror.o) definition of _PR_GetError /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_GetError ld: warning multiple definitions of symbol _PR_Free ../../../dist/bin/libnspr4.dylib(prmem.o) definition of _PR_Free /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_Free ld: warning multiple definitions of symbol _PR_DestroyLock ../../../dist/bin/libnspr4.dylib(ptsynch.o) definition of _PR_DestroyLock /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_DestroyLock ld: warning multiple definitions of symbol _PR_Calloc ../../../dist/bin/libnspr4.dylib(prmem.o) definition of _PR_Calloc /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_Calloc ld: warning multiple definitions of symbol _PR_Realloc ../../../dist/bin/libnspr4.dylib(prmem.o) definition of _PR_Realloc /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_Realloc ld: warning multiple definitions of symbol _PR_NewLock ../../../dist/bin/libnspr4.dylib(ptsynch.o) definition of _PR_NewLock /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_NewLock ld: warning multiple definitions of symbol _PR_Malloc ../../../dist/bin/libnspr4.dylib(prmem.o) definition of _PR_Malloc /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_Malloc ld: warning multiple definitions of symbol _PR_Lock ../../../dist/bin/libnspr4.dylib(ptsynch.o) definition of _PR_Lock /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_Lock ld: warning multiple definitions of symbol _PR_CeilingLog2 ../../../dist/bin/libnspr4.dylib(prlog2.o) definition of _PR_CeilingLog2 /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_CeilingLog2 ld: warning multiple definitions of symbol _PR_GetOSError ../../../dist/bin/libnspr4.dylib(prerror.o) definition of _PR_GetOSError /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_GetOSError ld: warning multiple definitions of symbol _PR_Unlock ../../../dist/bin/libnspr4.dylib(ptsynch.o) definition of _PR_Unlock /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_Unlock ld: warning multiple definitions of symbol _PR_SetError ../../../dist/bin/libnspr4.dylib(prerror.o) definition of _PR_SetError /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_SetError make[6]: *** [libmailnews.dylib] Error 1

This patch: * Adds -framework Carbon to mailnews/base/build/Makefile.in Thanks to mento for the suggestions I've tested that it compiles and starts up, can someone make sure the integration is what is expected?

Ok, tried to do a clobber build and now get the following: g++ -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -fpascal-strings -no-cpp-precomp -fno-common -fshort-wchar -I/Developer/Headers/FlatCarbon -pipe -DNDEBUG -DTRIMMED -O2 -fPIC -arch ppc -o libwidget_mac.dylib nsAppShell.o nsBidiKeyboard.o nsChildWindow.o nsClipboard.o nsDeleteObserver.o nsDragService.o nsDragHelperService.o nsFilePicker.o nsLookAndFeel.o nsMacEventHandler.o nsMacMessagePump.o nsMacResources.o nsMacTSMMessagePump.o nsMacWindow.o nsMenuX.o nsMenuBarX.o nsMenuItemX.o nsMimeMapper.o nsNativeThemeMac.o nsSound.o nsTSMStrategy.o nsToolkitBase.o nsToolkit.o nsWidgetFactory.o nsWindow.o nsMacNativeUnicodeConverter.o nsStylClipboardUtils.o nsMacControl.o nsNativeScrollbar.o nsRepeater.o nsWatchTask.o nsBaseWidget.o nsTransferable.o nsHTMLFormatConverter.o nsBaseDragService.o nsPrimitiveHelpers.o nsXPLookAndFeel.o nsClipboardHelper.o nsWidgetAtoms.o nsBaseClipboard.o nsBaseFilePicker.o nsNativeTheme.o -Wl,-dead_strip -framework QuickTime -framework IOKit ../../../dist/lib/libunicharutil_s.a -framework Carbon -L../../../dist/bin -lxpcom -lxpcom_core -L../../../dist/bin -L../../../dist/lib -lplds4 -lplc4 -lnspr4 -lgkgfx -Wl,-exported_symbols_list -Wl,/Users/ianneal/mozdev/mozilla/build/unix/gnu-ld-scripts/components-export-list -bundle ld: /usr/lib/gcc/darwin/3.3/libstdc++.a(eh_personality.o) illegal reference to symbol: ___cxa_begin_catch defined in indirectly referenced dynamic library /usr/lib/libstdc++.6.dylib ld: warning multiple definitions of symbol _PL_ArenaAllocate ../../../dist/bin/libplds4.dylib(plarena.o) definition of _PL_ArenaAllocate /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(plarena.o) definition of _PL_ArenaAllocate ld: warning multiple definitions of symbol _PL_InitArenaPool ../../../dist/bin/libplds4.dylib(plarena.o) definition of _PL_InitArenaPool /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(plarena.o) definition of _PL_InitArenaPool ld: warning multiple definitions of symbol _PL_FreeArenaPool ../../../dist/bin/libplds4.dylib(plarena.o) definition of _PL_FreeArenaPool /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(plarena.o) definition of _PL_FreeArenaPool ld: warning multiple definitions of symbol _PL_FinishArenaPool ../../../dist/bin/libplds4.dylib(plarena.o) definition of _PL_FinishArenaPool /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(plarena.o) definition of _PL_FinishArenaPool ld: warning multiple definitions of symbol _PL_ArenaRelease ../../../dist/bin/libplds4.dylib(plarena.o) definition of _PL_ArenaRelease /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(plarena.o) definition of _PL_ArenaRelease ld: warning multiple definitions of symbol _PL_ArenaGrow ../../../dist/bin/libplds4.dylib(plarena.o) definition of _PL_ArenaGrow /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(plarena.o) definition of _PL_ArenaGrow ld: warning multiple definitions of symbol _PL_ArenaFinish ../../../dist/bin/libplds4.dylib(plarena.o) definition of _PL_ArenaFinish /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(plarena.o) definition of _PL_ArenaFinish ld: warning multiple definitions of symbol _PL_CompactArenaPool ../../../dist/bin/libplds4.dylib(plarena.o) definition of _PL_CompactArenaPool /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(plarena.o) definition of _PL_CompactArenaPool ld: warning multiple definitions of symbol _PR_GetError ../../../dist/bin/libnspr4.dylib(prerror.o) definition of _PR_GetError /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_GetError ld: warning multiple definitions of symbol _PR_Free ../../../dist/bin/libnspr4.dylib(prmem.o) definition of _PR_Free /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_Free ld: warning multiple definitions of symbol _PR_DestroyLock ../../../dist/bin/libnspr4.dylib(ptsynch.o) definition of _PR_DestroyLock /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_DestroyLock ld: warning multiple definitions of symbol _PR_Calloc ../../../dist/bin/libnspr4.dylib(prmem.o) definition of _PR_Calloc /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_Calloc ld: warning multiple definitions of symbol _PR_Realloc ../../../dist/bin/libnspr4.dylib(prmem.o) definition of _PR_Realloc /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_Realloc ld: warning multiple definitions of symbol _PR_NewLock ../../../dist/bin/libnspr4.dylib(ptsynch.o) definition of _PR_NewLock /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_NewLock ld: warning multiple definitions of symbol _PR_Malloc ../../../dist/bin/libnspr4.dylib(prmem.o) definition of _PR_Malloc /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_Malloc ld: warning multiple definitions of symbol _PR_Lock ../../../dist/bin/libnspr4.dylib(ptsynch.o) definition of _PR_Lock /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_Lock ld: warning multiple definitions of symbol _PR_CeilingLog2 ../../../dist/bin/libnspr4.dylib(prlog2.o) definition of _PR_CeilingLog2 /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_CeilingLog2 ld: warning multiple definitions of symbol _PR_GetOSError ../../../dist/bin/libnspr4.dylib(prerror.o) definition of _PR_GetOSError /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_GetOSError ld: warning multiple definitions of symbol _PR_Unlock ../../../dist/bin/libnspr4.dylib(ptsynch.o) definition of _PR_Unlock /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_Unlock ld: warning multiple definitions of symbol _PR_SetError ../../../dist/bin/libnspr4.dylib(prerror.o) definition of _PR_SetError /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork(nsprPortX.o) definition of _PR_SetError make[6]: *** [libwidget_mac.dylib] Error 1 make[5]: *** [libs] Error 2 make[4]: *** [libs] Error 2 make[3]: *** [libs_tier_9] Error 2 make[2]: *** [tier_9] Error 2 make[1]: *** [alldep] Error 2 make: *** [alldep] Error 2

The QuickTime 7.0.4 update hosed non-SDK builds on 10.3.9. You need to use an SDK, 10.2.8 is recommended. This was bug 323348. See: http://developer.mozilla.org/en/docs/Mac_OS_X_Build_Prerequisites#Troubleshooting

I still get it, my .mozconfig in mozilla/ is: # optimized mozconfig file for SeaMonkey on OSX CC=gcc CXX=g++ CPP=cpp AS=as LD=ld # the following options don't yet work under gcc-on-win32 ac_add_options --disable-accessibility ac_add_options --disable-activex mk_add_options MOZ_CO_PROJECT=suite ac_add_options --enable-application=suite mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/suite-opt ac_add_options --enable-optimize=-O2 ac_add_options --with-macros-sdk=/Developer/SDKs/MacOSX10.2.8.sdk ac_add_options --enable-crypto ac_add_options --enable-svg ac_add_options --enable-canvas

(In reply to comment #14) > I still get it, my .mozconfig in mozilla/ is: > ac_add_options --with-macros-sdk=/Developer/SDKs/MacOSX10.2.8.sdk Okay, I don't know how to spell macos!

Right, now when I try to build it just sits on: checking for ANSI C header files...

This is how it looks with the patch and pref("mail.biff.animate_dock_icon", true); in mailnews.js. So, it seems to work :)

(In reply to comment #17) > Created an attachment (id=209454) [edit] > screenshot of patch in action > > This is how it looks with the patch and pref("mail.biff.animate_dock_icon", > true); in mailnews.js. So, it seems to work :) > Err, rather because of the mail.biff.show_alert pref I guess...

Hmm, well it does seem that none of mail.biff.animate_dock_icon and mail.biff.show_alert affect the behaviour in the screenshot. I just took that for granted... :-/

Comment on attachment 209361 [details] [diff] [review] Tweaked Patch v0.1a Tested, built and now have a "nice" bouncing icon when new emails arrive. No UI yet to change the pref.

Comment on attachment 209361 [details] [diff] [review] Tweaked Patch v0.1a I suspect some bitrot ;-)

Changes since v0.1a: * Unbitrotted patch * Added default for bouncing pref in mailnews.js * Added pref UI for setting bouncing pref

This patch: * Adds entry in help for new pref UI

Comment on attachment 210290 [details] [diff] [review] Revised patch inc pref UI v0.1b > var newMailNotificationAlertUI = document.getElementById("newMailNotificationAlert"); > newMailNotificationAlertUI.hidden = !("@mozilla.org/alerts-service;1" in Components.classes); >+ if (!/Mac/.test(navigator.platform)) >+ document.getElementById('newMailNotificationBounce').setAttribute("hidden", true); > } This should follow the style of the existing lines I quoted above.

Comment on attachment 210294 [details] [diff] [review] Patch for revised pref UI v0.1b >Index: mail_help.xhtml >=================================================================== >RCS file: /cvsroot/mozilla/extensions/help/resources/locale/en-US/mail_help.xhtml,v >retrieving revision 1.66 >diff -p -u -d -8 -r1.66 mail_help.xhtml >--- mail_help.xhtml 9 Dec 2005 00:39:45 -0000 1.66 >+++ mail_help.xhtml 31 Jan 2006 23:40:30 -0000 >@@ -4458,16 +4458,19 @@ to filter unwanted mail.</p> > not need to be enabled in order to display the new message alert. For > information on using Quick Launch, see > <a href="nav_help.xhtml#using_quick_launch">Using Quick Launch</a>.</p> > > <p>Once &brandShortName; Mail has been started, the new message alert will > continue to work even after you close the Mail window (as long as another > &brandShortName; application is running).</p> > </li> >+ <li class="mac"><strong>Animate the dock icon</strong>: Select this if you want >+ &brandShortName; Mail &amp; Newsgroups to animate the dock icon when new >+ messages arrive.</li> Unless "bounce" sounds odd, how about something like "...to bounce the &brandShortName; Dock icon when new messages arrives" or something similar (I trust your grammar more than mine)?

Comment on attachment 210350 [details] [diff] [review] Tweaked revised patch v0.1b1 >-REQUIRES += macmorefiles >+REQUIRES += macmorefiles >+CPPSRCS += nsMessengerOSXIntegration.cpp Nit: odd-looking indentation here.

(In reply to comment #27) > (From update of attachment 210350 [details] [diff] [review] [edit]) > >-REQUIRES += macmorefiles > >+REQUIRES += macmorefiles > >+CPPSRCS += nsMessengerOSXIntegration.cpp > Nit: odd-looking indentation here. > It is because of the way tabs fall when diffing, the actual file looks correct after being patched.

Changes since help patch v0.1b: * Changed to bounce from animate.

Comment on attachment 210517 [details] [diff] [review] Tweaked revised help patch v0.1b1 Hmm, I just noticed that we now say "Dock" in help, but in the ui we say "dock". - feel free to change it to "dock" (even though I suspect it should be "Dock").

(In reply to comment #30) > (From update of attachment 210517 [details] [diff] [review] [edit]) > Hmm, I just noticed that we now say "Dock" in help, but in the ui we say > "dock". > > - feel free to change it to "dock" (even though I suspect it should be "Dock"). > I'll make sure both are Dock at checkin unless anyone objects?

This patch is what was actually checked in, changes from v0.1b: * Changed dock -> Dock in pref panel / help Checking in (trunk) mailnews/base/build/Makefile.in; new revision: 1.77; previous revision: 1.76 mailnews/base/build/nsMsgFactory.cpp; new revision: 1.118; previous revision: 1.117 mailnews/base/src/Makefile.in; new revision: 1.126; previous revision: 1.125 mailnews/mailnews.js; new revision: 3.262; previous revision: 3.261 mailnews/base/prefs/resources/content/pref-notifications.xul; new revision: 1.12; previous revision: 1.11 mailnews/base/prefs/resources/content/pref-notifications.js; new revision: 1.6; previous revision: 1.5 mailnews/base/prefs/resources/locale/en-US/pref-notifications.dtd; new revision: 1.8; previous revision: 1.7 extensions/help/resources/locale/en-US/mail_help.xhtml; new revision: 1.67; previous revision: 1.66 done

Comment on attachment 213751 [details] [diff] [review] Checked in patch v0.1b2 (Checked into trunk / branch 1.8.1) Requesting approval for SM1.1a - touches some files shared with TB too so asking for 1.8.1 too - will probably need to sit on trunk for a bit first to make sure no regressions.

Comment on attachment 213751 [details] [diff] [review] Checked in patch v0.1b2 (Checked into trunk / branch 1.8.1) a=me given that it can bake and be tested on trunk before it goes in on branch - and that it gets branch approval for shared stuff as well :)

Comment on attachment 213751 [details] [diff] [review] Checked in patch v0.1b2 (Checked into trunk / branch 1.8.1) Checking in (branch 1.8.1) mailnews/base/build/Makefile.in; new revision: 1.74.8.2; previous revision: 1.74.8.1 mailnews/base/build/nsMsgFactory.cpp; new revision: 1.112.20.4; previous revision: 1.112.20.3 mailnews/base/src/Makefile.in; new revision: 1.122.8.2; previous revision: 1.122.8.1 mailnews/mailnews.js; new revision: 3.249.2.8; previous revision: 3.249.2.7 mailnews/base/prefs/resources/content/pref-notifications.xul; new revision: 1.9.22.3; previous revision: 1.9.22.2 mailnews/base/prefs/resources/content/pref-notifications.js; new revision: 1.5.44.1; previous revision: 1.5 mailnews/base/prefs/resources/locale/en-US/pref-notifications.dtd; new revision: 1.5.28.3; previous revision: 1.5.28.2 extensions/help/resources/locale/en-US/mail_help.xhtml; new revision: 1.62.2.6; previous revision: 1.62.2.5 done