With SeaMonkey 1.0beta on OS/2 I see that when I create a new identity for one of my accounts via M&N Account Settings -> Manage Identities... -> Add... I cannot select any other than the default outgoing SMTP server. The dropdown box only contains "Use Default Server" and a seperator. Once I finished adding the identity, I can change the SMTP server when I select to Edit... the identity.

Reproducible with Mozilla 1.8b2/20050304 and SeaMonkey 1.5a/20060117. There is no SMTP server dropdownbox in Mozilla 1.8b2/20050303 (and earlier) so this bug seems to be introduced by the patch for bug 202468.

I also get a message in the JS console Error: gIdentity has no properties Source File: chrome://messenger/content/am-addressing.js Line: 58 That is because gIdentity==null but that line is trying to get a key from it: if (gPrefInt.prefIsLocked("mail.identity." + gIdentity.key Seems like the identity copy that is done in initCompositionAndAddressing() in am-identity-edit.js doesn't work.

(In reply to comment #2) > I also get a message in the JS console > > Error: gIdentity has no properties > Source File: chrome://messenger/content/am-addressing.js > Line: 58 > > That is because gIdentity==null but that line is trying to get a key > from it: > if (gPrefInt.prefIsLocked("mail.identity." + gIdentity.key > > Seems like the identity copy that is done in initCompositionAndAddressing() > in am-identity-edit.js doesn't work. Good catch on that error! The identity "copying" that you refer to is not actually copying -- instead, the UI fields are getting initialized there, either from the existing identity or, if creating a new identity, from the default; but nothing is being done to initialize gIdentity (because there's no new identity object created until the user OK's the new fields). But if the code is changed to check gIdentity there, then the dropdown is initialized properly. Unfortunately, I don't really understand 'preference locking' so I don't know whether those 'disabled' attributes should be turned on or turned off for the null case. This is Thunderbird bug 313987, and is in the trunk as well as the 1.5 branch. I don't know if these am-*.js files are Core or forked.

Doh, I've had this patch sitting in my tree since goodness knows when...

Fix checked in to the trunk.

Comment on attachment 208921 [details] [diff] [review] Proposed patch Would be nice if this trivial shared code fix could make it in to the 1.8.0 branch for SeaMonkey.

*** Bug 313987 has been marked as a duplicate of this bug. ***

The fix works fine for thunderbird version 1.6a1 (20060114). Thanks Neil.