When ThrowUserError() shows a big red box telling you "Hey, wait!", you notice it. Simply writing "You cannot remove this group because it is in used" on a white background makes it appear as a normal message, nothing serious to take care of. I first thought the group was deleted till I finally took the time to read the message. ThrowUserError() would have made it clearer.

This makes groups/deleted.html.tmpl pretty useless now.

Comment on attachment 213772 [details] [diff] [review] patch, v1 This would cause a regression, in the sense of loosing the URL displaying which are the affected records (you aren't reintroducing the editgroups.cgi?action=del&group=[% gid FILTER url_quote %] link anywhere else).

Keep the URL to make vladd happy. I still pretend that this URL is useless, because clicking on the "go back" button of your web browser will show you the same screen.

I've said on IRC: <LpSolit> vladd: when you get the error from ThrowUserError(), you have no +other choice than clicking the "go back" button. This has exactly the same +effect as clicking the link I removed <vladd> LpSolit: but I need to press refresh as well. <LpSolit> ? <LpSolit> refreshing what? <LpSolit> you don't have to refresh anything <vladd> The screen. <LpSolit> i don't see why <vladd> If I press back, I simply get the old results. <LpSolit> which is exactly the screen you want <vladd> Would I have been so stupid to press delete if I saw any relations? Almost certainly there was some kind of mid-air, if I ended up there. <vladd> So I need to press Back, and then Refresh to see what actually changed and caused the error. <LpSolit> more probably you forgot to click on one of the checkboxes <vladd> Needless to say, over 50% of the admins will see the situation unchanged and +will certainly not press Refresh by themselves. <vladd> LpSolit: if you insist, you can clear my review- and restore it to review? bugzilla@chimpychompy

Comment on attachment 213992 [details] [diff] [review] patch, v2 Some people would prefer the link text to be more explanatory than just 'records'. But that is a minor minor nit. Please raise a new bug if you think that this same issue applies to the 'no changes made' message in the groups/change.html.tmpl file.

Checking in editgroups.cgi; /cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v <-- editgroups.cgi new revision: 1.67; previous revision: 1.66 done Checking in template/en/default/admin/groups/deleted.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/groups/deleted.html.tmpl,v <-- deleted.html.tmpl new revision: 1.3; previous revision: 1.2 done Checking in template/en/default/global/user-error.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v <-- user-error.html.tmpl new revision: 1.155; previous revision: 1.154 done

This patch applied cleanly on 2.22 and is required by bug 281181.

2.22: Checking in editgroups.cgi; /cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v <-- editgroups.cgi new revision: 1.65.2.3; previous revision: 1.65.2.2 done Checking in template/en/default/admin/groups/deleted.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/groups/deleted.html.tmpl,v <-- deleted.html.tmpl new revision: 1.2.2.1; previous revision: 1.2 done Checking in template/en/default/global/user-error.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v <-- user-error.html.tmpl new revision: 1.145.2.16; previous revision: 1.145.2.15 done