Closed
Bug 324371
Opened 19 years ago
Closed 18 years ago
about:logo should be a PNG image
Categories
(SeaMonkey :: General, defect)
SeaMonkey
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: xanthor+bz, Assigned: kairo)
References
()
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
image/png
|
neil
:
review+
neil
:
superreview+
|
Details |
(deleted),
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051205 SeaMonkey/1.5a
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051205 SeaMonkey/1.5a
The new about:logo of SeaMonkey is a GIF file.
Converting in PNG, we can save more than 2kb.
Reproducible: Always
Steps to Reproduce:
This bug may be a dupe of bug 242423 but as we're not talking about the same logo, I open this new bug.
Reporter | ||
Comment 1•19 years ago
|
||
$ ls -o
20247 about-logo.gif
17622 about-logo.png
Comment 2•18 years ago
|
||
The problem is that you can't change the logo to a .png image straight away: see netwerk/protocol/about/src/nsAboutRedirector.cpp, line 75. And you can't really change to about.png in nsAboutRedirector.cpp staright way either... That said, I would much rather prefer a png image since that would mean that you could have a drop-shadow on it (but I can imagine that it wouldn't look that good on some systems).
Assignee | ||
Comment 3•18 years ago
|
||
I think we need to either find a way for making the whole about: page app-specific (move it into chrome://branding/ in every Mozilla-based app) or make http://lxr.mozilla.org/seamonkey/source/netwerk/protocol/about/src/nsAboutRedirector.cpp#75 point to chrome://branding/content/logo.gif instead of chrome://global/content/logo.gif - which I think might be the best solution, actually...
Benjamin, does that sound like a good idea to you?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 4•18 years ago
|
||
Erm, sorry, I mean chrome://branding/content/logo.png as the new URL instead of chrome://global/content/logo.gif
Comment 5•18 years ago
|
||
It should definitely not be pointing to chrome://global
chrome://branding might be a good solution. What happens, though, if the app author doesn't provide an image at that location (which could be the common case for XR apps in the wild)?
Who links to about: anyway? Why do we have it?
Assignee | ||
Comment 6•18 years ago
|
||
Oh, wait... toolkit already points to "chrome://branding/content/about.png" instead of "about:logo" from about.xhtml, so this only affects xpfe-based apps.
Though I still think that not crossing the protocol boundaries (and therefore allowing stricter security) with using "about:logo" is probably a better diea than to point to a chrome:// URL from the about: page directly.
We at least are using "about:" as the "About SeaMonkey" page linked from the help menu, it looks like Firefox people have been updating the toolkit version as well though, even if they are using a separate window for the menu entry.
If no logo is provided in that location, I think we would display the "broken image" symbol...
Assignee | ||
Comment 7•18 years ago
|
||
OK, we'll not change this for old xpfe-based SeaMonkey, but we'll use a PNG for "suiterunner" (toolkit-based SeaMonkey).
This will be _no_ size reduction, in fact, the PNG I have here is a bit bigger than the current GIF (~30K) but it fits what toolkit's about window wants and looks much better than what we currently have.
I'll attach an image and a patch in a minute.
Blocks: suiterunner
Assignee | ||
Comment 8•18 years ago
|
||
This is the new image, modeled after http://lxr.mozilla.org/mozilla/source/browser/base/branding/about.png so that we fit the style intended for the toolkit about window.
Assignee: general → kairo
Attachment #209354 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #244427 -
Flags: superreview?(neil)
Attachment #244427 -
Flags: review?(neil)
Assignee | ||
Comment 9•18 years ago
|
||
Here's the trivial patch for packaging the new about.png (in the place used by toolkit's about: page)
Attachment #244428 -
Flags: superreview?(neil)
Attachment #244428 -
Flags: review?(neil)
Updated•18 years ago
|
Attachment #244427 -
Flags: superreview?(neil)
Attachment #244427 -
Flags: superreview+
Attachment #244427 -
Flags: review?(neil)
Attachment #244427 -
Flags: review+
Updated•18 years ago
|
Attachment #244428 -
Flags: superreview?(neil)
Attachment #244428 -
Flags: superreview+
Attachment #244428 -
Flags: review?(neil)
Attachment #244428 -
Flags: review+
Assignee | ||
Comment 10•18 years ago
|
||
FIXED for suiterunner - and as I said in comment #7 we won't fix this for xpfe-based SeaMonkey.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•