There are some missing checks in editgroups.cgi IMO. It should: 1) update groups in editparams.cgi (or more exactly in data/params) when a group used by it is renamed; 2) reject to delete a group if the group is used in editparams.cgi. If you set insidergroup to groupA and then you rename or delete groupA, editparams.cgi will still mention groupA as being the insidergroup despite this group no longer exists. And so all "private" comments and attachments are inaccessible. Marking as depending on bug 324783 as editparams.cgi should also not let you use inexistent groups. Again, I would tend to take it for 2.22.

Reversing dependencies.

If a group used by chartgroup, insidergroup or timetrackinggroup is renamed, update data/params accordingly. If one tries to delete it, reject this deletion.

Comment on attachment 223636 [details] [diff] [review] patch, v1 Group list only shows first parameter that uses the group. Other than that, this seems to work as advertised.

ooh, by all means. :) Can we backport this to the older branches that contain group names in editparams?

(19:50:45) LpSolit: justdave: on *all* branches? or 2.22 only? (19:52:15) justdave: umm, any that aren't locked to security-only yet (19:53:06) LpSolit: so 2.22 only (20:03:02) LpSolit: justdave: if you approve bug 323525 for 2.22, my patch would apply cleanly on the 2.22 branch too Meanwhile, here is the checkin for tip: Checking in editgroups.cgi; /cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v <-- editgroups.cgi new revision: 1.70; previous revision: 1.69 done Checking in template/en/default/admin/groups/list.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/groups/list.html.tmpl,v <-- list.html.tmpl new revision: 1.6; previous revision: 1.5 done Checking in template/en/default/global/user-error.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v <-- user-error.html.tmpl new revision: 1.169; previous revision: 1.168 done

Assuming bug 323525 is approved for 2.22, requesting approval for 2.22 too.

reopening just to make sure it doesn't get lost since we still have pending checkin

2.22: Checking in editgroups.cgi; /cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v <-- editgroups.cgi new revision: 1.65.2.1; previous revision: 1.65 done Checking in template/en/default/admin/groups/list.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/groups/list.html.tmpl,v <-- list.html.tmpl new revision: 1.4.2.2; previous revision: 1.4.2.1 done Checking in template/en/default/global/user-error.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v <-- user-error.html.tmpl new revision: 1.145.2.11; previous revision: 1.145.2.10 done