Closed Bug 324828 Opened 19 years ago Closed 19 years ago

[FIX]nsHTMLFormElement::ResolveName and various form.elements stuff should flush

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha1

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(2 files, 1 obsolete file)

Like so
(deleted), patch
sicking
: review+
peterv
: superreview+
Details | Diff | Splinter Review
Tp regression fix updated to jst's comments
(deleted), patch
Details | Diff | Splinter Review
Attached patch Like so (deleted) — — Splinter Review
Attachment #209803 - Flags: superreview?(peterv)
Attachment #209803 - Flags: review?(bugmail)
Summary: nsHTMLFormElement::ResolveName and various form.elements stuff should flush → [FIX]nsHTMLFormElement::ResolveName and various form.elements stuff should flush
Target Milestone: --- → mozilla1.9alpha
Attachment #209803 - Flags: superreview?(peterv) → superreview+
Fixed
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
This caused a bit of a Tp regression; I think I have an idea of why. Working on a fix.
Attached patch Attempt to fix pageload regression (obsolete) (deleted) — — Splinter Review
Comment on attachment 211100 [details] [diff] [review] Attempt to fix pageload regression I'd change the default arguments in the new methods in nsHTMLInputElement to required ones to force people to think about when to flush or not when using these methods, but r+sr=jst either way.
Attachment #211100 - Flags: superreview+
Attachment #211100 - Flags: review+
I just checked this in; keeping my fingers crossed.
Attachment #211100 - Attachment is obsolete: true
Yep. Tp went back down on btek, luna, and monkey. In fact, it went down from where it used to be.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: