Closed
Bug 324969
Opened 19 years ago
Closed 19 years ago
[FIX]Major Rlk increase on balsa
Categories
(Core :: Web Painting, defect, P1)
Core
Web Painting
Tracking
()
VERIFIED
FIXED
mozilla1.9alpha1
People
(Reporter: ispiked, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
During 2005-01-25 08:30 and 2005-01-25 19:20 the Rlk on balsa went from 1.80KB to around 6.33KB. CCing people who made checkins during this time. http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-01-25+08%3A30&maxdate=2005-01-25+19%3A20&cvsroot=%2Fcvsroot ----------------------------------------------leaks------leaks%------bloat------bloat% TOTAL 6480 250.65% 15036624 -0.94% --NEW-LEAKS-----------------------------------leaks------leaks%----------------------- imgContainer 320 - imgContainerGIF 264 - gfxImageFrame 1176 - nsWeakReference 48 - nsImageGTK 2772 - nsProperties 40 - nsVoidArray 16 300.00% TOTAL 4636
Are you really hunting down a year old leaks ;) I suspect that you ment http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-01-25+08%3A30&maxdate=2006-01-25+19%3A20&cvsroot=%2Fcvsroot
Assignee | ||
Comment 2•19 years ago
|
||
ispiked, want to cc the people who actually checked in during the relevant interval? I sure as heck did not check in then.... I'll try to reproduce this when I get home, but I'll need to update a tree to tip and such.
The properties stuff I did does not use nsProperties, so that's likly not it. And none of the pages that we run the leak tests on use svg, mathml or xslt which is all my other patches *should* have affected.
Looks most likely to be me
Assignee | ||
Comment 5•19 years ago
|
||
So... I tried debugging this and it looks to me like we're leaking some of the display list structs. I can't tell for sure because sometime in the last week the format of the stuff that XPCOM leak logging outputs changed, so now the post-processing tools don't work right.... Compare something like: /home/bzbarsky/mozilla/vanilla/obj-seamonkey/dist/bin/components/libgklayout.so(_ZN8nsCOMPtrI9nsIWidgetE20Assert_NoQueryNeededEv+0x3b)[0xb690282f] to what the tools actually look for.
Assignee | ||
Updated•19 years ago
|
Assignee: nobody → roc
Component: General → Layout: View Rendering
OS: Linux → All
Product: Firefox → Core
QA Contact: general → ian
Hardware: PC → All
Assignee | ||
Comment 6•19 years ago
|
||
Most of the patch is just adding ctor/dtor logging for the structs. The part that fixes the leaks is actually calling our destructors such that subclass destructors will get called.
Assignee: roc → bzbarsky
Status: NEW → ASSIGNED
Attachment #209938 -
Flags: superreview?(roc)
Attachment #209938 -
Flags: review?(roc)
Assignee | ||
Updated•19 years ago
|
Priority: -- → P1
Summary: Major Rlk increase on balsa → [FIX]Major Rlk increase on balsa
Target Milestone: --- → mozilla1.9alpha
Comment on attachment 209938 [details] [diff] [review] Proposed patch that's really great. Thanks so very much.
Attachment #209938 -
Flags: superreview?(roc)
Attachment #209938 -
Flags: superreview+
Attachment #209938 -
Flags: review?(roc)
Attachment #209938 -
Flags: review+
Assignee | ||
Comment 8•19 years ago
|
||
I'll land this on Sunday.
Assignee | ||
Comment 9•19 years ago
|
||
Fix checked in. Leaks are back down.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•19 years ago
|
Status: RESOLVED → VERIFIED
Comment 10•19 years ago
|
||
Not just leaks, it also seems to have brought Tp on btek back to where it was.
Comment 11•19 years ago
|
||
And I just noticed you mentioned that in bug 317375 :-)
Updated•6 years ago
|
Component: Layout: View Rendering → Layout: Web Painting
You need to log in
before you can comment on or make changes to this bug.
Description
•