User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060129 Firefox/1.6a1 Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060129 Firefox/1.6a1 There are four font apis on Mac: Font Manager, ATS for Fonts, ATSUI and Cocoa. We have to consider these problems: - Symnol gets Sigma-psi-mu-... (Font Manager): bug 213702 - Indic font families lost (Font Manager, ATS): bug 246527 - Hiragino Kaku Gothic fonts are split into different families (Font Manager, ATS) - No font family -> font face conversion in ATS - ATSFontFamilyGetName is broken for non-ASCII font names(ATS): bug 213702 comment 16 I think ATSUI font functions are too low-level and we need a lot to do manage typeface management (...-Regular vs just the family name, Italic vs Oblique, weight conversion, etc.) while Cocoa already implements these. We also need to determin how to implement font fallback and symbolic font conversion (e.g. math fonts) Reproducible: Always Steps to Reproduce:

just copied the relevant portion in nsDeviceContextMac (+ my work at bug 170854). Maybe we can swith to Cocoa for this too?

and I have nsFontMetricsMac files (that cannot be compiled yet). Are they needed immediately?

Ok, looks like we've done a similar approach for a number of things in the font code bits. I'll probably do a dump of my code into CVS on monday or tuesday to avoid more duplication. There are various combinations of FMFontManager, ATS, and Font Manager that should be able to give us the necessary functionality. At the very least, we'd end up being bug-compatible with Safari on OSX.

Yamashita-san, how does this impact bug 121540 (QD --> ATSUI) ?

(In reply to comment #8) > Yamashita-san, how does this impact bug 121540 (QD --> ATSUI) ? The two are fairly independent, although text measurement code paths are borrowed from the changes to nsATSUIUtils.cpp there.

Implements system fonts selection and adding error checks. We can't use ATSUFindFontFromName that simple; the typeface obtained is not guaranteed to be Regular.

So we have to use Cocoa or implement this by hand using ATSUFindFont... for family name and style name.

Hi, thanks for the patches! I'm not too convinced of some of the changes, though. Like I mentioned earlier, it sounds like we've both been heading in the same direction -- I've got some Cocoa-using changes locally as well since I landed the first bare-bones set of code. However, please come talk to me first; otherwise we're going to continue to do duplicate work. A number of us are in channel #gfx on irc, please join us there.

besides fixing the build bustage, this introduces a new font manager developed in bug 246527 and bug 121540. We need to add bold/italic synth management, but at least we get regular typeface when we need it with this...

goes into thebes/public

assuming those are the right thing, they should just be added to gfxAtsuiFonts.{cpp,h} directly. the tabs should be removed, and it should match the rest of the code in thebes (no ns* prefix, etc).

this merges nsMacFonts.* with gfxAtsuiFonts. Also adds reasonable whitespace metrics measurement and a germ for (future) bold & italic synth handling.

This was fixed by a different implementation of ATSUI on mac