The fragment hyperlinks in the new about:licen[cs]e don't work. According to Neil, it's because the about: protocol doesn't implement fragment indentifiers. Therefore, I am going to write a JS solution. Gerv

A JS solution would suck for various reasons. And it turns out that you can make fragment identifiers work, as long as you precede them with a full URL. So, patch on the way. Gerv

Comment on attachment 210140 [details] [diff] [review] Patch v.1 >- <p><a href="#top">Return to top</a>.</p> >+ <p><a href="about:license#top">Return to top</a>.</p> This one doesn't get corrected, I guess it's missing a class="correctme" on the <p> tag. r=me with that (well those, if toolkit has the same bug) fixed.

Checked into trunk. I'll verify it then get branch approval. Checking in toolkit/content/license.html; /cvsroot/mozilla/toolkit/content/license.html,v <-- license.html new revision: 1.2; previous revision: 1.1 done Checking in ./xpfe/global/resources/content/license.html; /cvsroot/mozilla/xpfe/global/resources/content/license.html,v <-- license.htmlnew revision: 1.2; previous revision: 1.1 done Gerv

Comment on attachment 210140 [details] [diff] [review] Patch v.1 Verified as working on the trunk. Requesting branch approval. Gerv

Comment on attachment 210140 [details] [diff] [review] Patch v.1 Note: unlike stable branch or frozen trunk approval you have to specify the victim - 1.8.1 branch is another module owner chore.

Checked in on branch. Checking in toolkit/content/license.html; /cvsroot/mozilla/toolkit/content/license.html,v <-- license.html new revision: 1.1.2.3; previous revision: 1.1.2.2 done Checking in ./xpfe/global/resources/content/license.html; /cvsroot/mozilla/xpfe/global/resources/content/license.html,v <-- license.htmlnew revision: 1.1.2.3; previous revision: 1.1.2.2 done Gerv

Verified with a current Firefox 1.8 branch build.